Skip to content

Commit c1d2b68

Browse files
authored
fix: some controller functions never complete (#123)
1 parent 8b675cf commit c1d2b68

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

android/src/main/kotlin/com/github/josxha/maplibre/MapLibrePlugin.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class MapLibrePlugin :
2222
PluginRegistry.RequestPermissionsResultListener,
2323
PermissionManagerHostApi {
2424
private var lifecycle: Lifecycle? = null
25-
private lateinit var permissionManagerApi: PermissionManagerHostApi
2625

2726
private lateinit var flutterAssets: FlutterPlugin.FlutterAssets
2827

lib/src/native/widget_state_jni.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,8 @@ final class MapLibreMapStateJni extends MapLibreMapState
289289
await runOnPlatformThread(() {
290290
final completer = Completer<void>();
291291
jniMap.moveCamera(cameraUpdate);
292+
// TODO: jni causes sometimes a deadlock, complete immediately for now
293+
completer.complete();
292294
/*jniMap.moveCamera$1(
293295
cameraUpdate,
294296
jni.MapLibreMap_CancelableCallback.implement(
@@ -331,6 +333,8 @@ final class MapLibreMapStateJni extends MapLibreMapState
331333
await runOnPlatformThread(() async {
332334
final completer = Completer<void>();
333335
jniMap.animateCamera$2(cameraUpdate, nativeDuration.inMilliseconds);
336+
// TODO: jni causes sometimes a deadlock, complete immediately for now
337+
completer.complete();
334338
/*jniMap.animateCamera$3(
335339
cameraUpdate,
336340
nativeDuration.inMilliseconds,
@@ -378,6 +382,8 @@ final class MapLibreMapStateJni extends MapLibreMapState
378382
await runOnPlatformThread(() {
379383
final completer = Completer<void>();
380384
jniMap.animateCamera$2(cameraUpdate, nativeDuration.inMilliseconds);
385+
// TODO: jni causes sometimes a deadlock, complete immediately for now
386+
completer.complete();
381387
/*jniMap.animateCamera$3(
382388
cameraUpdate,
383389
nativeDuration.inMilliseconds,

0 commit comments

Comments
 (0)