Skip to content

Conversation

@josxha
Copy link
Owner

@josxha josxha commented Oct 16, 2025

@josxha josxha added this to the v0.3.1 milestone Oct 16, 2025
@josxha josxha requested a review from Copilot October 16, 2025 11:07
@github-project-automation github-project-automation bot moved this to Backlog in maplibre dev Oct 16, 2025
@josxha josxha moved this from Backlog to In Progress in maplibre dev Oct 16, 2025
@josxha josxha changed the title feat: add minZoom, maxZoom feat: add minZoom, maxZoom Oct 16, 2025
@josxha josxha enabled auto-merge (squash) October 16, 2025 11:08
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.50%. Comparing base (0c7ceb7) to head (dc90217).
⚠️ Report is 1 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josxha josxha disabled auto-merge October 16, 2025 11:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds minZoom and maxZoom support across style layers and platform controllers to control layer visibility by zoom level.

  • Introduces non-nullable minZoom/maxZoom on StyleLayer and Layer base classes, with defaults.
  • Wires minZoom/maxZoom through Android, iOS, and Web style controllers into the underlying platform APIs.
  • Exposes minzoom/maxzoom in the Web interop LayerSpecification.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lib/src/style/layers/style_layer.dart Makes minZoom/maxZoom non-nullable with default values and documents ranges.
lib/src/style/layers/*_style_layer.dart Passes minZoom/maxZoom defaults through various layer constructors.
lib/src/platform/web/style_controller.dart Forwards minZoom/maxZoom to JS LayerSpecification.
lib/src/platform/web/interop/map.dart Adds minzoom/maxzoom fields to LayerSpecification interop.
lib/src/platform/ios/style_controller.dart Always sets minimumZoomLevel/maximumZoomLevel on native layer.
lib/src/platform/android/style_controller.dart Always sets min/max zoom on native layer.
lib/src/layer/layer.dart Adds minZoom/maxZoom to high-level Layer and includes in hashCode.
lib/src/layer/*_layer.dart Adds minZoom/maxZoom to public Layer constructors and forwards to StyleLayer.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2025

Deploying flutter-maplibre with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc90217
Status: ✅  Deploy successful!
Preview URL: https://342e364f.flutter-maplibre.pages.dev
Branch Preview URL: https://feat-minzoom-maxzoom.flutter-maplibre.pages.dev

View logs

@josxha josxha enabled auto-merge (squash) October 16, 2025 11:16
@josxha josxha linked an issue Oct 16, 2025 that may be closed by this pull request
@josxha josxha merged commit 6ad8444 into main Oct 16, 2025
17 checks passed
@josxha josxha deleted the feat/minZoom-maxZoom branch October 16, 2025 11:19
@github-project-automation github-project-automation bot moved this from In Progress to Done in maplibre dev Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEATURE] support minZoom / maxZoom in the layers

2 participants