feat: jni 0.15.2 #409
feat: jni 0.15.2 #409
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the jni package dependency, though there's a discrepancy between the title (0.15.1) and the actual version (0.15.2). The update includes adapting to API changes in the jni package where certain methods no longer require the _engineId parameter.
Key Changes:
- Updated jni dependency from
^0.15.0to^0.15.2 - Modified
getJContext()to use the updated jni API without_engineIdparameter - Updated js-yaml transitive dependency from 3.14.1 to 3.14.2 in docs lockfile
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| maplibre/pubspec.yaml | Updates jni package dependency version from ^0.15.0 to ^0.15.2 |
| maplibre/lib/src/platform/android/functions.dart | Adapts getJContext() to new jni API by removing _engineId parameter from androidApplicationContext call |
| docs/yarn.lock | Updates js-yaml dependency version from 3.14.1 to 3.14.2 with updated checksum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
Deploying flutter-maplibre with
|
| Latest commit: |
5f7f864
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://245774a6.flutter-maplibre.pages.dev |
| Branch Preview URL: | https://feat-jni-0-15-1.flutter-maplibre.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
jni 0.15.1 introduced a breaking change, this pr migrates the code to jni ^0.15.2
dart-lang/native#2777