Precedence of $EDITOR over config.ini's editor entry

[ccjmne]

Hey 👋

I use my trusty $EDITOR always, but I like to spice it up with some extra params here and there for various files, like turning on some spelling check when creating a Git commit.

Basically, my mental model until now was: $EDITOR is the default, and each app may have its specific override if relevant.

With Klog, I'd like to vim + and go straight to the the end of the file (that's what + does). It's really no big deal and I can definitely live without that, but I'm a bit surprised to see that you chose, purposely, to have $EDITOR not quite be the fallback but rather take precedence over whatever is set through Klog's editor entry in its config.ini.

Could you share some insight as to why you went for it this way? Would you be open to changing that? :)

--
On another note, it's a bit curious to have klog config show editor = <empty> (it doesn't literally say <empty>) when one sets both their $EDITOR and the editor in config.ini.

In reading the (as always, excellent) --help, I understand that the klog config is indeed only exposing the configuration from the ini rather than the "effective" configuration...
But that's still leave you scratching your head for a little while when again, both your env's $EDITOR and the ini's editor are set: you don't get exactly only the content from your config file either, since it gets evicted when it would be superseded in another context for the effective configuration.
I feel like something here is off, one way or the other.

--
I've never really toyed with Go and I have to say that I'm somewhat surprised by its syntax, but I'll try to get the lay of the land if you'd be open to changing some of these behaviours: I'd like to start contributing more to your delightfully neat project!

[jotaen]

Could you share some insight as to why you went for it this way? Would you be open to changing that? :)

There isn’t really a deliberate reasoning behind this, I only documented the behaviour for the records.

I don’t feel strongly about the precedence, but I think your reasoning makes sense: i.e., $EDITOR is probably generic/general-purpose, whereas the editor entry in config.ini can be used as a klog-specific override.

On another note, it's a bit curious to have klog config show editor = (it doesn't literally say ) when one sets both their $EDITOR and the editor in config.ini.

Oh, that shouldn’t be and is a bug. The klog config command is supposed to output what’s in the file.

but I'll try to get the lay of the land if you'd be open to changing some of these behaviours:

Feel free to take a look if you are motivated. Just a heads-up: I briefly looked into this, and I’m not sure yet how trivial this is to fix. Most of the config-related logic lives in app/config.go. I think both issues are related to the way in which the eventual effective configuration is merged from 3 sources. Currently, env variables always take precedence over the file-based config, but I think this mechanism is too coarse-grained: e.g., in contrast to the editor config file entry taking precedence over the $EDITOR variable, the $NO_COLOR variable should take precedence over the colour_scheme file entry. So I’m thinking whether the merging mechanism needs some basic refactoring to accommodate this fix properly.

[jotaen]

This issue is resolved by #398 and will be included in the next release. (No ETA on the release yet, though.)

[ccjmne]

Oh woah, thank you very much!