Remove DEFAULT_ALGORITHM

Author: luhn

jwt/api_jws.py

@@ -26,9 +26,6 @@
     from .algorithms import AllowedPrivateKeys, AllowedPublicKeys
 
 
-DEFAULT_ALGORITHM = "DEFAULT_ALGORITHM"
-
-
 class PyJWS:
     header_typ = "JWT"
 
@@ -109,7 +106,7 @@ def encode(
         self,
         payload: bytes,
         key: AllowedPrivateKeys | PyJWK | str | bytes,
-        algorithm: str | None = DEFAULT_ALGORITHM,
+        algorithm: str | None = None,
         headers: dict[str, Any] | None = None,
         json_encoder: type[json.JSONEncoder] | None = None,
         is_payload_detached: bool = False,
@@ -118,12 +115,13 @@ def encode(
         segments = []
 
         # declare a new var to narrow the type for type checkers
-        algorithm_: str = algorithm if algorithm is not None else "none"
-        if algorithm_ == DEFAULT_ALGORITHM:
+        if algorithm is None:
             if isinstance(key, PyJWK):
                 algorithm_ = key.algorithm_name
             else:
                 algorithm_ = "HS256"
+        else:
+            algorithm_ = algorithm
 
         # Prefer headers values if present to function parameters.
         if headers:

jwt/api_jwt.py

@@ -46,7 +46,7 @@ def encode(
         self,
         payload: dict[str, Any],
         key: AllowedPrivateKeys | PyJWK | str | bytes,
-        algorithm: str | None = api_jws.DEFAULT_ALGORITHM,
+        algorithm: str | None = None,
         headers: dict[str, Any] | None = None,
         json_encoder: type[json.JSONEncoder] | None = None,
         sort_headers: bool = True,

tests/test_api_jws.py

@@ -562,13 +562,13 @@ def test_decode_invalid_crypto_padding(self, jws):
         assert "Invalid crypto padding" in str(exc.value)
 
     def test_decode_with_algo_none_should_fail(self, jws, payload):
-        jws_message = jws.encode(payload, key=None, algorithm=None)
+        jws_message = jws.encode(payload, key=None, algorithm="none")
 
         with pytest.raises(DecodeError):
             jws.decode(jws_message, algorithms=["none"])
 
     def test_decode_with_algo_none_and_verify_false_should_pass(self, jws, payload):
-        jws_message = jws.encode(payload, key=None, algorithm=None)
+        jws_message = jws.encode(payload, key=None, algorithm="none")
         jws.decode(jws_message, options={"verify_signature": False})
 
     def test_get_unverified_header_returns_header_values(self, jws, payload):