fix(jwks): handle PyJWKSet returned from cache in get_jwk_set#1160
Open
armorbreak001 wants to merge 1 commit into
Open
fix(jwks): handle PyJWKSet returned from cache in get_jwk_set#1160armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
When the JWK set cache is populated externally with a PyJWKSet instance (e.g. from a pre-fetched JWKS), get_jwk_set() raised PyJWKClientError because it expected only dict or None from the cache. Return cached PyJWKSet objects directly. Fixes jpadilla#914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the JWK set cache is populated externally with a
PyJWKSetinstance (e.g. from a pre-fetched JWKS stored externally),get_jwk_set()raisedPyJWKClientErrorbecause it only expecteddictorNonefrom the cache.The
isinstance(data, dict)guard correctly validates fresh fetch results (which are dicts from JSON), but fails when the cache contains aPyJWKSetput there by user code — which is what the type hints forJWKSetCache.put()suggest is the intended usage.Before this fix:
Fix: Return cached
PyJWKSetobjects directly, before the dict type check.Fixes #914