Skip to content

Commit 135811c

Browse files
authored
Merge pull request #174 from timkpaine/main
Reconcile hard fork now that access is restored
2 parents 49ffa3e + 55e2a00 commit 135811c

37 files changed

Lines changed: 12783 additions & 10386 deletions

.github/CODEOWNERS

Lines changed: 0 additions & 9 deletions
This file was deleted.
File renamed without changes.

.yarnrc.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
nodeLinker: node-modules

CONTRIBUTING.md

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ If you have any questions about the contribution process, please feel free to se
1212

1313
Note: You will need NodeJS to build the extension package.
1414

15+
```bash
16+
pip install -e .[dev]
17+
```
18+
1519
The `jlpm` command is JupyterLab's pinned version of
1620
[yarn](https://yarnpkg.com/) that is installed with JupyterLab. You may use
1721
`yarn` or `npm` in lieu of `jlpm` below.
@@ -20,12 +24,16 @@ The `jlpm` command is JupyterLab's pinned version of
2024
# Clone the repo to your local environment
2125
# Change directory to the jupyter-fs directory
2226
# Install package in development mode
23-
make dev_install
27+
jlpm
28+
cd js
29+
jlpm build
30+
cd ..
31+
jlpm develop
2432
```
2533

2634
### Configure
2735

28-
You'll need to set the contents manager class in the jupyter server config. Paste the following json:
36+
You'll need to set the contents manager class in the jupyter server config. Paste the following json into your config:
2937

3038
```json
3139
{
@@ -35,6 +43,12 @@ You'll need to set the contents manager class in the jupyter server config. Past
3543
}
3644
```
3745

46+
or run lab with
47+
48+
```bash
49+
jupyter lab --ServerApp.contents_manager_class="jupyterfs.metamanager.MetaManager"
50+
```
51+
3852
into a file named `${CONFIG}/jupyter_server_config.json`, where `CONFIG` is any of the config paths returned by the `jupyter --paths` command.
3953

4054
### Rebuild after you make changes

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ build: ## build python/javascript
99
python -m build .
1010

1111
develop: ## install to site-packages in editable mode
12-
python -m pip install --upgrade build docker-compose "jupyterlab>=3.5,<4" pip setuptools twine wheel
12+
python -m pip install --upgrade build docker-compose jupyterlab pip setuptools twine wheel
1313
python -m pip install -vvv .[develop]
1414

1515
install: ## install to site-packages

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
#
66

77
<p>
8-
<a href="https://dev.azure.com/tpaine154/jupyter/_apis/build/status/jpmorganchase.jupyter-fs?branchName=main"><img alt="azure ci status" src="https://dev.azure.com/tpaine154/jupyter/_apis/build/status/jpmorganchase.jupyter-fs?branchName=main"></a>
9-
<a href="https://ci.appveyor.com/project/telamonian/jupyter-fs/branch/main"><img alt="appveyor ci status (telamonian fork)" src="https://ci.appveyor.com/api/projects/status/d8flhw12vpvgime4/branch/main?svg=true"></a>
8+
<a href="https://github.com/jpmorganchase/jupyter-fs/actions?query=workflow%3A%22Build+Status%22"><img alt="build status" src="https://github.com/jpmorganchase/jupyter-fs/workflows/Build%20Status/badge.svg?branch=main"></a>
109
<a href="https://pypi.python.org/pypi/jupyter-fs"><img alt="pypi package" src="https://img.shields.io/pypi/v/jupyter-fs.svg"></a>
1110
<a href="https://www.npmjs.com/package/jupyter-fs"><img alt="npm package" src="https://img.shields.io/npm/v/jupyter-fs.svg"></a>
1211
</p>
@@ -69,7 +68,7 @@ Add specifications for additional contents managers in your user settings (in th
6968

7069
You should see your new filebrowsers pop up in the left-hand sidebar instantly when you save your settings:
7170

72-
![](https://raw.githubusercontent.com/jpmorganchase/jupyter-fs/master/docs/osfs_example.png)
71+
![](https://raw.githubusercontent.com/jpmorganchase/jupyter-fs/main/docs/osfs_example.png)
7372

7473

7574
## Use with auth/credentials
@@ -91,7 +90,7 @@ Any stretch of a `"url"` that is enclosed in double-brackets `{{VAR}}` will be t
9190

9291
When you save the above `"resouces"` config, a dialog box will pop asking for the `username` and `passwd` values:
9392

94-
![](https://raw.githubusercontent.com/jpmorganchase/jupyter-fs/master/docs/remote_example.png)
93+
![](https://raw.githubusercontent.com/jpmorganchase/jupyter-fs/main/docs/remote_example.png)
9594

9695
Once you enter those values and hit ok, the new filebrowsers will then immediately appear in the sidebar:
9796

@@ -160,10 +159,10 @@ Any filesystem resources specified in any server-side config file will be merged
160159

161160
## Development
162161

163-
See [CONTRIBUTING.md](https://github.com/jpmorganchase/jupyter-fs/blob/master/CONTRIBUTING.md) for guidelines.
162+
See [CONTRIBUTING.md](https://github.com/jpmorganchase/jupyter-fs/blob/main/CONTRIBUTING.md) for guidelines.
164163

165164

166165
## License
167166

168167
This software is licensed under the Apache 2.0 license. See the
169-
[LICENSE](https://github.com/jpmorganchase/jupyter-fs/blob/master/LICENSE) and [AUTHORS](https://github.com/jpmorganchase/jupyter-fs/blob/master/AUTHORS) files for details.
168+
[LICENSE](https://github.com/jpmorganchase/jupyter-fs/blob/main/LICENSE) and [AUTHORS](https://github.com/jpmorganchase/jupyter-fs/blob/main/AUTHORS) files for details.

ci/mac/enable_sharing.sh

100644100755
File mode changed.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
PLATFORM_INFO = {"darwin": "mac", "linux": "linux", "win32": "windows"}
77
PLATFORMS = set(PLATFORM_INFO.keys())
88

9+
pytest_plugins = ["pytest_jupyter.jupyter_server"]
10+
911

1012
def pytest_configure(config):
1113
# register the platform markers

js/jest.config.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,13 @@ module.exports = {
1313
testPathIgnorePatterns: ["/lib/", "/node_modules/"],
1414
testRegex: "tests\/.*\.test\.ts[x]?$", // eslint-disable-line no-useless-escape
1515
transform: {
16-
"\\.tsx?$": "ts-jest",
16+
"\\.tsx?$": [
17+
"ts-jest", {
18+
// in tsconfig.test.json, rootDir is parent of both tests and src dirs
19+
tsconfig: "tsconfig.test.json",
20+
},
21+
],
1722
"\\.jsx?$": "babel-jest",
1823
},
1924
transformIgnorePatterns: [`node_modules/(?!(${esModules}))`],
20-
globals: {
21-
"ts-jest": {
22-
// in tsconfig.test.json, rootDir is parent of both tests and src dirs
23-
tsconfig: "tsconfig.test.json",
24-
},
25-
},
2625
};

js/package.json

Lines changed: 36 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"postpack": "shx rm README.md",
2929
"prepack": "shx cp ../README.md .",
3030
"prepublishOnly": "jlpm clean && jlpm clean:labextension && jlpm integrity && jlpm build:prod",
31-
"test": "jest --coverage --collectCoverageFrom=src/*.{ts,tsx}",
31+
"test": "jest --coverage",
3232
"test:browser": "../ci/browser_check.sh",
3333
"watch": "run-p watch:lib watch:labextension",
3434
"watch:lib": "tsc -b -w",
@@ -41,55 +41,60 @@
4141
"style/**/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf}"
4242
],
4343
"dependencies": {
44-
"@jupyterlab/application": "^3.0.0",
45-
"@jupyterlab/apputils": "^3.0.0",
46-
"@jupyterlab/coreutils": "^5.0.0",
47-
"@jupyterlab/docmanager": "^3.0.0",
48-
"@jupyterlab/docregistry": "^3.0.0",
49-
"@jupyterlab/filebrowser": "^3.0.0",
50-
"@jupyterlab/services": "^6.0.0",
51-
"@jupyterlab/settingregistry": "^3.0.0",
52-
"@jupyterlab/ui-components": "^3.0.0",
53-
"@lumino/algorithm": "^1.3.3",
54-
"@lumino/disposable": "^1.4.3",
44+
"@jupyterlab/application": "^4.0.0",
45+
"@jupyterlab/apputils": "^4.0.0",
46+
"@jupyterlab/coreutils": "^6.0.0",
47+
"@jupyterlab/docmanager": "^4.0.0",
48+
"@jupyterlab/docregistry": "^4.0.0",
49+
"@jupyterlab/filebrowser": "^4.0.0",
50+
"@jupyterlab/services": "^7.0.0",
51+
"@jupyterlab/settingregistry": "^4.0.0",
52+
"@jupyterlab/statusbar": "^4.0.0",
53+
"@jupyterlab/translation": "^4.0.0",
54+
"@jupyterlab/ui-components": "^4.0.0",
55+
"@lumino/algorithm": "^2.0.0",
56+
"@lumino/commands": "^2.0.0",
57+
"@lumino/disposable": "^2.1.1",
58+
"@lumino/messaging": "^2.0.0",
59+
"@lumino/signaling": "^2.0.0",
60+
"@lumino/widgets": "^2.0.0",
5561
"@material-ui/core": "^4.11.3",
56-
"@types/file-saver": "^2.0.1",
57-
"@types/jszip": "^3.4.1",
5862
"file-saver": "^2.0.5",
5963
"jszip": "^3.7.0",
60-
"react": "^17.0.0",
61-
"react-dom": "^17.0.0",
64+
"react": "^18.2.0",
65+
"react-dom": "^18.2.0",
6266
"tree-finder": "^0.0.13"
6367
},
6468
"devDependencies": {
6569
"@babel/core": "^7.0.0",
6670
"@babel/preset-env": "^7.20.2",
67-
"@jupyterlab/builder": "^3.0.0",
68-
"@types/jest": "^26.0.22",
69-
"@types/react": "^17.0.0",
70-
"@types/react-dom": "^17.0.0",
71+
"@jupyterlab/builder": "^4.0.0",
72+
"@types/file-saver": "^2.0.1",
73+
"@types/jest": "^29.5.1",
74+
"@types/jszip": "^3.4.1",
75+
"@types/react": "^18.0.0",
76+
"@types/react-dom": "^18.0.0",
7177
"@typescript-eslint/eslint-plugin": "^5.45.0",
7278
"@typescript-eslint/parser": "^5.45.0",
7379
"eslint": "^8.29.0",
7480
"eslint-plugin-import": "^2.23.4",
75-
"eslint-plugin-jsdoc": "^39.6.4",
81+
"eslint-plugin-jsdoc": "^44.2.4",
7682
"eslint-plugin-prefer-arrow": "^1.2.3",
7783
"eslint-plugin-react": "^7.24.0",
78-
"eslint-plugin-unicorn": "^45.0.1",
84+
"eslint-plugin-unicorn": "^47.0.0",
7985
"isomorphic-fetch": "^3.0.0",
80-
"jest": "^26",
86+
"jest": "^29.5.0",
87+
"jest-environment-jsdom": "^29.5.0",
8188
"jest-junit": "^16.0.0",
8289
"jest-raw-loader": "^1.0.1",
83-
"mkdirp": "^1.0.4",
84-
"rimraf": "^3.0.2",
90+
"mkdirp": "^3.0.1",
91+
"rimraf": "^5.0.1",
8592
"shx": "^0.3.3",
86-
"ts-jest": "^26.5.4",
87-
"typescript": "^4.2.4",
93+
"source-map-loader": "^4.0.1",
94+
"ts-jest": "^29.1.0",
95+
"typescript": "^4.5.0",
8896
"yarn-deduplicate": "^6.0.0"
8997
},
90-
"resolutions": {
91-
"**/@types/react": "^17.0.0"
92-
},
9398
"sideEffects": [
9499
"style/**/*.css",
95100
"style/index.js"
@@ -106,7 +111,7 @@
106111
}
107112
}
108113
},
109-
"extension": true,
114+
"extension": "lib/index.js",
110115
"outputDir": "../jupyterfs/labextension",
111116
"schemaDir": "schema"
112117
}

0 commit comments

Comments
 (0)