Merge pull request #333 from painebot/tkp/scroll

Log on double command register to help find race condition, update demo

Author: timkpaine

README.md

@@ -20,6 +20,7 @@ A plugin for JupyterLab that lets you set up and use as many filebrowsers as you
 
 The backend is built on top of [PyFilesystem](https://github.com/PyFilesystem/pyfilesystem2) and [fsspec](https://filesystem-spec.readthedocs.io/en/latest/), while the frontend is built on top of [tree-finder](https://github.com/tree-finder/tree-finder).
 
+![](https://raw.githubusercontent.com/jpmorganchase/jupyter-fs/main/docs/img/demo.gif)
 
 ## Install
 
@@ -176,7 +177,7 @@ Similar to PyFilesystem, `fsspec` also allows for a `"url"` based opening scheme
 
 ## Server-side settings
 
-If you prefer to set up your filesystem resources in the server-side config, you can do so. For example, you can set up a local filesystem by adding the following to your `jupyter_server_config.py` file:
+If you prefer to set up your filesystem resources in the server-side config, you can do so. For example, you can set up a local filesystem by adding the following to your `jupyter_server_config.py` file (or `jupyter_lab_config.py` or `jupyter_notebook_config.py` depending on your setup):
 
 ```python
 c.JupyterFs.resources = [

docs/img/demo.gif

@@ -477,11 +477,17 @@ export async function createDynamicCommands(
     items = [...factories].map(factory => {
       const key = _openWithKeyForFactory(factory.label || factory.name);
       const label = factory.label || factory.name;
-      openWithCommands.push(app.commands.addCommand(key, {
-        execute: args => Promise.all(Array.from(map(model.selection, item => app.commands.execute("docmanager:open", { path: Path.fromarray(item.row.path), ...args })))),
-        label,
-        isVisible: () => true,
-      }));
+      if (!app.commands.hasCommand(key)) {
+        openWithCommands.push(app.commands.addCommand(key, {
+          execute: args => Promise.all(Array.from(map(model.selection, item => app.commands.execute("docmanager:open", { path: Path.fromarray(item.row.path), ...args })))),
+          label,
+          isVisible: () => true,
+        }));
+      } else {
+        // Update label in case it has changed
+        // eslint-disable-next-line no-console
+        console.log("Skipping existing command:", key);
+      }
       return openWith.addItem({
         args: { factory: factory.name, label: factory.label || factory.name },
         command: key,