Skip to content

Commit d701952

Browse files
committed
cleanup some biome warnings
1 parent 636c282 commit d701952

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

packages/embla-carousel/src/Carousel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export const Carousel = forwardRef<HTMLElement, CarouselProps>(
8585
getEmblaApi?.(emblaApi);
8686
}
8787
return undefined;
88-
}, [emblaApi]);
88+
}, [emblaApi, getEmblaApi]);
8989

9090
const [ariaVariant, setAriaVariant] =
9191
useState<CarouselAriaVariant>("group");

packages/embla-carousel/src/CarouselAutoplayIndicator.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export const CarouselAutoplayIndicator = forwardRef<
100100
animationFrameId.current = null;
101101
}
102102
};
103-
}, [circumference, duration, slideIndex, isPlaying, isPaused]);
103+
}, [circumference, duration, isPlaying, isPaused]);
104104

105105
return (
106106
<div

packages/embla-carousel/src/CarouselCard.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ export const CarouselCard = forwardRef<HTMLDivElement, CarouselCardProps>(
5959
const { ariaVariant } = useCarouselContext();
6060

6161
return (
62+
// biome-ignore lint/a11y/useAriaPropsSupportedByRole: role is set dynamically and is valid
6263
<div
6364
aria-roledescription="slide"
6465
className={clsx([withBaseName(), className])}

packages/embla-carousel/src/CarouselSlides.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export const CarouselSlides = forwardRef<HTMLDivElement, CarouselSlidesProps>(
9595
emblaApi.off("scroll", scrollCallback);
9696
emblaApi.off("pointerDown", pointerDownCallback);
9797
};
98-
}, [emblaApi]);
98+
}, [emblaApi, setAnnouncementState]);
9999

100100
useLayoutEffect(() => {
101101
if (focusSlideIndex >= 0) {
@@ -118,7 +118,7 @@ export const CarouselSlides = forwardRef<HTMLDivElement, CarouselSlidesProps>(
118118
if (disableSlideAnnouncements === false) {
119119
setAnnouncementState(undefined);
120120
}
121-
}, [disableSlideAnnouncements]);
121+
}, [disableSlideAnnouncements, setAnnouncementState]);
122122

123123
useEffect(() => {
124124
if (

packages/embla-carousel/src/CarouselTabList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export const CarouselTabList = forwardRef<HTMLDivElement, CarouselTabListProps>(
121121

122122
return (
123123
<CarouselTabRenderer
124-
key={`carouselTab-${scrollSnapIndex}}`}
124+
key={`carouselTab-${slideNodes?.[scrollSnapIndex].id}}`}
125125
ref={(element: HTMLButtonElement) => {
126126
buttonRefs.current[scrollSnapIndex] = element;
127127
}}

0 commit comments

Comments
 (0)