Change Colors on InlayHints and Diagnostics?

[austgulen]

Firstly, I really enjoy your theme @jpwol ! It is definetly the best green theme I have ever used:)
I only had one question. Is there a way to change the InlayHint and Diagnostics colors (like hint)? I could not seem to get it to work from the readme. I am also fairly new to nvim, so it could just be a stupid mistake from my side?

on_highlight = function(hl, c)
        hl.LspInlayHint = { bg = c.none, fg = c.none }
        -- hl.LspInlayHint = { bg = c.bg, fg = c.fg }
        -- hl.LspInlayHint = { bg = "NONE", fg = c.fg }
      end,

[jpwol]

Hi, thanks for your feedback it means a lot!

Firstly, the highlight groups you're looking for are DiagnosticVirtualText highlights. Specifically, DiagnosticVirtualTextHint, DiagnosticVirtualTextError, ect.

However, this behavior is unexpected. Could you please open it as an issue (with the screenshot) and reference the highlight groups I gave you so I can get this fixed?

[jpwol]

The fix has been pushed, so you don't have to bother changing highlight groups if you don't want!

[austgulen]

Amazing, and sorry for the late response! I just pulled the new version, and it looks great!
As for the inlay hint color border, am I correctly identifying it as LspInlayHint? I seem to be unable to change the default here :S

on_highlight = function(hl, c)
        -- hl.LspInlayHint = { fg = c.fg, italic = true }
        hl.LspInlayHint = { fg = c.fg, bg = "NONE", italic = true }
        -- hl.LspInlayHint = { bg = c.bg, fg = c.fg }
      end,

[jpwol]

Oh haha, I see what the issue is. Your function is on_highlight instead of on_highlights with an s at the end.

Either way, this should still be fixed. I'm reopening this discussion until I get a fix pushed.

Thank you for the kind words and thank you for your patience, I'll have it taken care of sometime tomorrow afternoon.

Edit: I just saw that section of the readme is incorrect, that part is fixed now

[jpwol]

Also, keep in mind that when you do

hl.LspInlayHint = { fg = c.fg, italic = true }

This will clear the highlight for bg. If you want to preserve a style choice, be it fg, bg, italic, or bold, set it instead with

hl.LspInlayHint.fg = c.fg
hl.LspInlayHint.italic = true

The reason is that you're assigning a new lua table to that highlight group which doesn't include the information from the old lua table. If your desire is to completely clear out the previous highlights and reassign your own then your way is fine, but I figured I should mention it.

[austgulen]

That was it! Now it is perfect :) Thank you so much for the help!

[jpwol]

Fix for the Inlay Hints was just pushed, so it's optional if you keep your own highlight for it or not.