Skip to content

Commit 36ed9fc

Browse files
authored
Effect: Remove demos & visual tests of the transfer effect
The transfer effect is deprecated and not present unless `$.uiBackCompat` is set to `true`. In previous UI versions, the default was including the backwards compat layer so these demos & tests worked; now they do not by default. Just remove them. Fixes gh-2278 Closes gh-2291
1 parent c934995 commit 36ed9fc

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

demos/effect/default.html

-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#button { padding: .5em 1em; text-decoration: none; }
1212
#effect { width: 240px; height: 170px; padding: 0.4em; position: relative; }
1313
#effect h3 { margin: 0; padding: 0.4em; text-align: center; }
14-
.ui-effects-transfer { border: 2px dotted gray; }
1514
</style>
1615
<script src="../../external/requirejs/require.js"></script>
1716
<script src="../bootstrap.js" data-modules="effects-all">
@@ -25,8 +24,6 @@
2524
// some effects have required parameters
2625
if ( selectedEffect === "scale" ) {
2726
options = { percent: 50 };
28-
} else if ( selectedEffect === "transfer" ) {
29-
options = { to: "#button", className: "ui-effects-transfer" };
3027
} else if ( selectedEffect === "size" ) {
3128
options = { to: { width: 200, height: 60 } };
3229
}
@@ -75,7 +72,6 @@ <h3 class="ui-widget-header ui-corner-all">Effect</h3>
7572
<option value="shake">Shake</option>
7673
<option value="size">Size</option>
7774
<option value="slide">Slide</option>
78-
<option value="transfer">Transfer</option>
7975
</select>
8076

8177
<button id="button" class="ui-state-default ui-corner-all">Run Effect</button>

tests/visual/effects/all.html

-6
Original file line numberDiff line numberDiff line change
@@ -169,12 +169,6 @@
169169
</div>
170170
</li>
171171

172-
<li>
173-
<div class="effect" id="transfer">
174-
<p>Transfer to first element</p>
175-
</div>
176-
</li>
177-
178172
<li>
179173
<div class="effect" id="addClass">
180174
<p>addClass</p>

tests/visual/effects/effects.js

-8
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,6 @@ effect( "#slideUp", "slide", { direction: "up" } );
8383
effect( "#slideLeft", "slide", { direction: "left" } );
8484
effect( "#slideRight", "slide", { direction: "right" } );
8585

86-
$( "#transfer" ).on( "click", function() {
87-
$( this )
88-
.addClass( "current" )
89-
.effect( "transfer", { to: $( "div" ).eq( 0 ) }, 1000, function() {
90-
$( this ).removeClass( "current" );
91-
} );
92-
} );
93-
9486
$( "#addClass" ).on( "click", function() {
9587
$( this ).addClass( "current", duration, function() {
9688
$( this ).removeClass( "current" );

0 commit comments

Comments
 (0)