Skip to content

Commit e292560

Browse files
committed
Use no periods for partial phrases, like other providers
Note, this is fairly inconsistent across providers but when we see inconsistences, we should try to pick which way to go and since most providers have an incomplete sentence in these validation and helper texts, it makes sense to try to keep this non-sentence structure. I was noticing the english message catalog had the same partial sentence with and without the period: ``` msgid "Must start with a letter and contain only letters, numbers, and underscores" msgstr "" msgid "Must start with a letter and contain only letters, numbers, and underscores." msgstr "" ``` See: ManageIQ/manageiq#23665
1 parent 1bd8b87 commit e292560

File tree

1 file changed

+2
-2
lines changed
  • app/models/manageiq/providers/proxmox/infra_manager/vm/operations

1 file changed

+2
-2
lines changed

app/models/manageiq/providers/proxmox/infra_manager/vm/operations/snapshot.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def params_for_create_snapshot
1414
:id => 'name',
1515
:label => _('Name'),
1616
:isRequired => true,
17-
:helperText => _('Must start with a letter and contain only letters, numbers, and underscores.'),
17+
:helperText => _('Must start with a letter and contain only letters, numbers, and underscores'),
1818
:validate => [
1919
{:type => 'required'},
2020
{:type => 'pattern', :pattern => '^[a-zA-Z][a-zA-Z0-9_]*$', :message => _('Must start with a letter and contain only letters, numbers, and underscores')}
@@ -34,7 +34,7 @@ def params_for_create_snapshot
3434
:onText => _('Yes'),
3535
:offText => _('No'),
3636
:isDisabled => current_state != 'on',
37-
:helperText => _('Snapshotting the memory is only available if the VM is powered on.')
37+
:helperText => _('Snapshotting the memory is only available if the VM is powered on')
3838
}
3939
]
4040
}

0 commit comments

Comments
 (0)