Merge pull request #189 from jrnold/update-deprecated-function-warnings

Refactor discrete_scale calls to use named arguments for palette

Author: jrnold

R/calc.R

@@ -54,13 +54,13 @@ calc_pal <- function() {
 #' @export
 #' @seealso See \code{\link{theme_calc}()} for examples.
 scale_fill_calc <- function(...) {
-  discrete_scale("fill", "calc", calc_pal(), ...)
+  discrete_scale("fill", palette = calc_pal(), ...)
 }
 
 #' @export
 #' @rdname scale_calc
 scale_colour_calc <- function(...) {
-  discrete_scale("colour", "calc", calc_pal(), ...)
+  discrete_scale("colour", palette = calc_pal(), ...)
 }
 
 #' @export
@@ -90,7 +90,7 @@ calc_shape_pal <- function() {
 #' @export
 #' @seealso \code{\link{theme_calc}()} for examples.
 scale_shape_calc <- function(...) {
-  discrete_scale("shape", "calc", calc_shape_pal(), ...)
+  discrete_scale("shape", palette = calc_shape_pal(), ...)
 }
 
 # PT_TO_MM <- 0.352778

R/canva.R

@@ -48,7 +48,7 @@ canva_pal <- function(palette = "Fresh and bright") {
 #' @inheritParams canva_pal
 #' @export
 scale_colour_canva <- function(..., palette = "Fresh and bright") {
-  discrete_scale("colour", "canva", canva_pal(palette), ...)
+  discrete_scale("colour", palette = canva_pal(palette), ...)
 }
 
 #' @export
@@ -58,5 +58,5 @@ scale_color_canva <- scale_colour_canva
 #' @export
 #' @rdname scale_colour_canva
 scale_fill_canva <- function(..., palette = "Fresh and bright") {
-  discrete_scale("fill", "canva", canva_pal(palette), ...)
+  discrete_scale("fill", palette = canva_pal(palette), ...)
 }

R/colorblind.R

@@ -24,7 +24,7 @@ colorblind_pal <- function() {
 #' @rdname colorblind
 #' @export
 scale_colour_colorblind <- function(...) {
-  discrete_scale("colour", "colorblind", colorblind_pal(), ...)
+  discrete_scale("colour", palette = colorblind_pal(), ...)
 }
 
 #' @rdname colorblind
@@ -34,5 +34,5 @@ scale_color_colorblind <- scale_colour_colorblind
 #' @rdname colorblind
 #' @export
 scale_fill_colorblind <- function(...) {
-  discrete_scale("fill", "colorblind", colorblind_pal(), ...)
+  discrete_scale("fill", palette = colorblind_pal(), ...)
 }

R/economist.R

@@ -112,7 +112,7 @@ economist_pal <- function(fill = TRUE) {
 #' @seealso \code{\link{theme_economist}()} for examples.
 #' @export
 scale_colour_economist <- function(...) {
-  discrete_scale("colour", "economist", economist_pal(), ...)
+  discrete_scale("colour", palette = economist_pal(), ...)
 }
 
 #' @rdname scale_economist
@@ -122,7 +122,7 @@ scale_color_economist <- scale_colour_economist
 #' @rdname scale_economist
 #' @export
 scale_fill_economist <- function(...) {
-  discrete_scale("fill", "economist", economist_pal(), ...)
+  discrete_scale("fill", palette = economist_pal(), ...)
 }
 
 #' ggplot color theme based on the Economist

R/excel.R

@@ -50,13 +50,13 @@ excel_new_pal <- function(theme = "Office Theme") {
 #' @export
 #' @example inst/examples/ex-theme_excel.R
 scale_fill_excel <- function(...) {
-  discrete_scale("fill", "excel", excel_pal(line = FALSE), ...)
+  discrete_scale("fill", palette = excel_pal(line = FALSE), ...)
 }
 
 #' @export
 #' @rdname scale_excel
 scale_colour_excel <- function(...) {
-  discrete_scale("colour", "excel", excel_pal(line = TRUE), ...)
+  discrete_scale("colour", palette = excel_pal(line = TRUE), ...)
 }
 
 #' @export
@@ -74,7 +74,7 @@ scale_color_excel <- scale_colour_excel
 #' @example inst/examples/ex-theme_excel_new.R
 #' @export
 scale_colour_excel_new <- function(theme = "Office Theme", ...) {
-  discrete_scale("colour", "excel_new", excel_new_pal(theme), ...)
+  discrete_scale("colour", palette = excel_new_pal(theme), ...)
 }
 
 #' @export
@@ -84,7 +84,7 @@ scale_color_excel_new <- scale_colour_excel_new
 #' @export
 #' @rdname scale_excel_new
 scale_fill_excel_new <- function(theme = "Office Theme", ...) {
-  discrete_scale("fill", "excel_new", excel_new_pal(theme), ...)
+  discrete_scale("fill", palette = excel_new_pal(theme), ...)
 }
 
 #' ggplot theme based on old Excel plots

R/few.R

@@ -59,7 +59,7 @@ few_pal <- function(palette = "Medium") {
 #' @rdname scale_few
 #' @export
 scale_colour_few <- function(palette = "Medium", ...) {
-  discrete_scale("colour", "few", few_pal(palette), ...)
+  discrete_scale("colour", palette = few_pal(palette), ...)
 }
 
 #' @export
@@ -69,7 +69,7 @@ scale_color_few <- scale_colour_few
 #' @export
 #' @rdname scale_few
 scale_fill_few <- function(palette = "Light", ...) {
-  discrete_scale("fill", "few", few_pal(palette), ...)
+  discrete_scale("fill", palette = few_pal(palette), ...)
 }
 
 #' Theme based on Few's "Practical Rules for Using Color in Charts"
@@ -141,5 +141,5 @@ few_shape_pal <- function() {
 #'   scale uses.
 #' @export
 scale_shape_few <- function(...) {
-  discrete_scale("shape", "few", few_shape_pal(), ...)
+  discrete_scale("shape", palette = few_shape_pal(), ...)
 }

R/fivethirtyeight.R

@@ -63,7 +63,7 @@ fivethirtyeight_pal <- function() {
 #' @seealso \code{\link{theme_fivethirtyeight}()} for examples.
 #' @export
 scale_colour_fivethirtyeight <- function(...) {
-  discrete_scale("colour", "economist", fivethirtyeight_pal(), ...)
+  discrete_scale("colour", palette = fivethirtyeight_pal(), ...)
 }
 
 #' @rdname scale_fivethirtyeight
@@ -73,5 +73,5 @@ scale_color_fivethirtyeight <- scale_colour_fivethirtyeight
 #' @rdname scale_fivethirtyeight
 #' @export
 scale_fill_fivethirtyeight <- function(...) {
-  discrete_scale("fill", "economist", fivethirtyeight_pal(), ...)
+  discrete_scale("fill", palette = fivethirtyeight_pal(), ...)
 }

R/gdocs.R

@@ -113,13 +113,13 @@ gdocs_pal <- function() {
 #' @export
 #' @seealso See \code{\link{theme_gdocs}()} for examples.
 scale_fill_gdocs <- function(...) {
-  discrete_scale("fill", "gdocs", gdocs_pal(), ...)
+  discrete_scale("fill", palette = gdocs_pal(), ...)
 }
 
 #' @export
 #' @rdname scale_gdocs
 scale_colour_gdocs <- function(...) {
-  discrete_scale("colour", "gdocs", gdocs_pal(), ...)
+  discrete_scale("colour", palette = gdocs_pal(), ...)
 }
 
 #' @export

R/hc.R

@@ -89,7 +89,7 @@ hc_pal <- function(palette = "default") {
 #' @rdname scale_hc
 #' @export
 scale_colour_hc <- function(palette = "default", ...) {
-  discrete_scale("colour", "hc", hc_pal(palette), ...)
+  discrete_scale("colour", palette = hc_pal(palette), ...)
 }
 
 #' @rdname scale_hc
@@ -99,5 +99,5 @@ scale_color_hc <- scale_colour_hc
 #' @rdname scale_hc
 #' @export
 scale_fill_hc <- function(palette = "default", ...) {
-  discrete_scale("fill", "hc", hc_pal(palette), ...)
+  discrete_scale("fill", palette = hc_pal(palette), ...)
 }

R/pander.R

@@ -302,7 +302,7 @@ palette_pander <- function(n, random_order = FALSE) {
 #' @seealso \code{\link{theme_pander}()}
 #' @export
 scale_color_pander <- function(...) {
-  discrete_scale("colour", "pander", palette_pander, ...)
+  discrete_scale("colour", palette = palette_pander, ...)
 }
 
 
@@ -314,5 +314,5 @@ scale_colour_pander <- scale_color_pander
 #' @rdname scale_pander
 #' @export
 scale_fill_pander <- function(...) {
-  discrete_scale("fill", "pander", palette_pander, ...)
+  discrete_scale("fill", palette = palette_pander, ...)
 }