Added support for internal identifiers.

Author: jscarle

Diff for: src/LightResults.Extensions.GeneratedIdentifier/GeneratedIdentifierSourceGenerator.cs

@@ -72,6 +72,7 @@ private static bool Filter(SyntaxNode syntaxNode, CancellationToken cancellation
         var containingDeclarations = namedTypeSymbol.GetContainingDeclarations(cancellationToken);
         var symbolName = namedTypeSymbol.Name;
         var isStruct = namedTypeSymbol.TypeKind == TypeKind.Struct;
+        var isPublic = namedTypeSymbol.DeclaredAccessibility == Accessibility.Public;
 
         var attribute = context.Attributes[0].AttributeClass!;
         if (attribute.TypeArguments.Length != 1)
@@ -107,7 +108,7 @@ private static bool Filter(SyntaxNode syntaxNode, CancellationToken cancellation
                 break;
         }
 
-        var symbol = new Identifier(containingDeclarations, symbolName, isStruct, declaredValueType, fullValueType);
+        var symbol = new Identifier(containingDeclarations, symbolName, isStruct, isPublic, declaredValueType, fullValueType);
 
         return symbol;
     }
@@ -119,6 +120,7 @@ private static void GenerateIdentifier(SourceProductionContext context, Immutabl
             var symbolNamespace = symbol.ContainingDeclarations.ToNamespace();
             var symbolName = symbol.Name;
             var isStruct = symbol.IsStruct;
+            var isPublic = symbol.IsPublic;
             var declaredValueType = symbol.DeclaredValueType;
             var fullValueType = symbol.FullValueType;
 
@@ -157,7 +159,7 @@ namespace {symbolNamespace};
             source.AppendLine($$"""
                                 [TypeConverter(typeof({{symbolName}}TypeConverter))]
                                 [JsonConverter(typeof({{symbolName}}JsonConverter))]
-                                {{(isStruct ? "readonly" : "sealed")}} partial {{(isStruct ? "struct" : "class")}} {{symbolName}} :
+                                {{(isPublic ? "public" : "internal")}} {{(isStruct ? "readonly" : "sealed")}} partial {{(isStruct ? "struct" : "class")}} {{symbolName}} :
                                     ICreatableValueObject<{{declaredValueType}}, {{symbolName}}>,
                                 """
             );
@@ -664,7 +666,7 @@ private static Result Validate({{declaredValueType}} value)
             );
 
             source.AppendLine($$"""
-                                public class {{symbolName}}TypeConverter : TypeConverter
+                                {{(isPublic ? "public" : "internal")}} sealed class {{symbolName}}TypeConverter : TypeConverter
                                 {
                                     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
                                     {
@@ -683,7 +685,7 @@ public override bool CanConvertFrom(ITypeDescriptorContext? context, Type source
                                 """
             );
             source.AppendLine($$"""
-                                public class {{symbolName}}JsonConverter : JsonConverter<{{symbolName}}>
+                                {{(isPublic ? "public" : "internal")}} sealed class {{symbolName}}JsonConverter : JsonConverter<{{symbolName}}>
                                 {
                                     public override void Write(Utf8JsonWriter writer, {{symbolName}} identifier, JsonSerializerOptions options)
                                     {
@@ -730,13 +732,15 @@ private readonly record struct Identifier(
         EquatableImmutableArray<Declaration> ContainingDeclarations,
         string Name,
         bool IsStruct,
+        bool IsPublic,
         string DeclaredValueType,
         string FullValueType
     )
     {
         public EquatableImmutableArray<Declaration> ContainingDeclarations { get; } = ContainingDeclarations;
         public string Name { get; } = Name;
         public bool IsStruct { get; } = IsStruct;
+        public bool IsPublic { get; } = IsPublic;
         public string DeclaredValueType { get; } = DeclaredValueType;
         public string FullValueType { get; } = FullValueType;
     }

Diff for: src/LightResults.Extensions.GeneratedIdentifier/LightResults.Extensions.GeneratedIdentifier.csproj

@@ -36,7 +36,7 @@
     <!-- Output -->
     <PropertyGroup>
         <AssemblyName>LightResults.Extensions.GeneratedIdentifier</AssemblyName>
-        <Version>9.0.0-preview.8</Version>
+        <Version>9.0.0-preview.9</Version>
         <AssemblyVersion>9.0.0.0</AssemblyVersion>
         <FileVersion>9.0.0.0</FileVersion>
         <NeutralLanguage>en-US</NeutralLanguage>

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateGuidIdentifier_WithNamespace.verified.txt

@@ -21,7 +21,7 @@ namespace MyProject.Identifiers;
 
 [TypeConverter(typeof(TestGuidIdTypeConverter))]
 [JsonConverter(typeof(TestGuidIdJsonConverter))]
-readonly partial struct TestGuidId :
+public readonly partial struct TestGuidId :
     ICreatableValueObject<Guid, TestGuidId>,
     IParsableValueObject<TestGuidId>,
     IValueObject<Guid, TestGuidId>,
@@ -199,7 +199,7 @@ readonly partial struct TestGuidId :
     }
 }
 
-public class TestGuidIdTypeConverter : TypeConverter
+public sealed class TestGuidIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -215,7 +215,7 @@ public class TestGuidIdTypeConverter : TypeConverter
     }
 }
 
-public class TestGuidIdJsonConverter : JsonConverter<TestGuidId>
+public sealed class TestGuidIdJsonConverter : JsonConverter<TestGuidId>
 {
     public override void Write(Utf8JsonWriter writer, TestGuidId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateGuidIdentifier_WithoutNamespace.verified.txt

@@ -19,7 +19,7 @@ using LightResults.Extensions.ValueObjects;
 
 [TypeConverter(typeof(TestGuidIdTypeConverter))]
 [JsonConverter(typeof(TestGuidIdJsonConverter))]
-readonly partial struct TestGuidId :
+public readonly partial struct TestGuidId :
     ICreatableValueObject<Guid, TestGuidId>,
     IParsableValueObject<TestGuidId>,
     IValueObject<Guid, TestGuidId>,
@@ -197,7 +197,7 @@ readonly partial struct TestGuidId :
     }
 }
 
-public class TestGuidIdTypeConverter : TypeConverter
+public sealed class TestGuidIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -213,7 +213,7 @@ public class TestGuidIdTypeConverter : TypeConverter
     }
 }
 
-public class TestGuidIdJsonConverter : JsonConverter<TestGuidId>
+public sealed class TestGuidIdJsonConverter : JsonConverter<TestGuidId>
 {
     public override void Write(Utf8JsonWriter writer, TestGuidId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateIntIdentifier_WithNamespace.verified.txt

@@ -21,7 +21,7 @@ namespace MyProject.Identifiers;
 
 [TypeConverter(typeof(TestIntIdTypeConverter))]
 [JsonConverter(typeof(TestIntIdJsonConverter))]
-readonly partial struct TestIntId :
+public readonly partial struct TestIntId :
     ICreatableValueObject<int, TestIntId>,
     IParsableValueObject<TestIntId>,
     IValueObject<int, TestIntId>,
@@ -202,7 +202,7 @@ readonly partial struct TestIntId :
     }
 }
 
-public class TestIntIdTypeConverter : TypeConverter
+public sealed class TestIntIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -218,7 +218,7 @@ public class TestIntIdTypeConverter : TypeConverter
     }
 }
 
-public class TestIntIdJsonConverter : JsonConverter<TestIntId>
+public sealed class TestIntIdJsonConverter : JsonConverter<TestIntId>
 {
     public override void Write(Utf8JsonWriter writer, TestIntId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateIntIdentifier_WithoutNamespace.verified.txt

@@ -19,7 +19,7 @@ using LightResults.Extensions.ValueObjects;
 
 [TypeConverter(typeof(TestIntIdTypeConverter))]
 [JsonConverter(typeof(TestIntIdJsonConverter))]
-readonly partial struct TestIntId :
+public readonly partial struct TestIntId :
     ICreatableValueObject<int, TestIntId>,
     IParsableValueObject<TestIntId>,
     IValueObject<int, TestIntId>,
@@ -200,7 +200,7 @@ readonly partial struct TestIntId :
     }
 }
 
-public class TestIntIdTypeConverter : TypeConverter
+public sealed class TestIntIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -216,7 +216,7 @@ public class TestIntIdTypeConverter : TypeConverter
     }
 }
 
-public class TestIntIdJsonConverter : JsonConverter<TestIntId>
+public sealed class TestIntIdJsonConverter : JsonConverter<TestIntId>
 {
     public override void Write(Utf8JsonWriter writer, TestIntId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateLongIdentifier_WithNamespace.verified.txt

@@ -21,7 +21,7 @@ namespace MyProject.Identifiers;
 
 [TypeConverter(typeof(TestLongIdTypeConverter))]
 [JsonConverter(typeof(TestLongIdJsonConverter))]
-readonly partial struct TestLongId :
+public readonly partial struct TestLongId :
     ICreatableValueObject<long, TestLongId>,
     IParsableValueObject<TestLongId>,
     IValueObject<long, TestLongId>,
@@ -202,7 +202,7 @@ readonly partial struct TestLongId :
     }
 }
 
-public class TestLongIdTypeConverter : TypeConverter
+public sealed class TestLongIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -218,7 +218,7 @@ public class TestLongIdTypeConverter : TypeConverter
     }
 }
 
-public class TestLongIdJsonConverter : JsonConverter<TestLongId>
+public sealed class TestLongIdJsonConverter : JsonConverter<TestLongId>
 {
     public override void Write(Utf8JsonWriter writer, TestLongId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateLongIdentifier_WithoutNamespace.verified.txt

@@ -19,7 +19,7 @@ using LightResults.Extensions.ValueObjects;
 
 [TypeConverter(typeof(TestLongIdTypeConverter))]
 [JsonConverter(typeof(TestLongIdJsonConverter))]
-readonly partial struct TestLongId :
+public readonly partial struct TestLongId :
     ICreatableValueObject<long, TestLongId>,
     IParsableValueObject<TestLongId>,
     IValueObject<long, TestLongId>,
@@ -200,7 +200,7 @@ readonly partial struct TestLongId :
     }
 }
 
-public class TestLongIdTypeConverter : TypeConverter
+public sealed class TestLongIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -216,7 +216,7 @@ public class TestLongIdTypeConverter : TypeConverter
     }
 }
 
-public class TestLongIdJsonConverter : JsonConverter<TestLongId>
+public sealed class TestLongIdJsonConverter : JsonConverter<TestLongId>
 {
     public override void Write(Utf8JsonWriter writer, TestLongId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateShortIdentifier_WithNamespace.verified.txt

@@ -21,7 +21,7 @@ namespace MyProject.Identifiers;
 
 [TypeConverter(typeof(TestShortIdTypeConverter))]
 [JsonConverter(typeof(TestShortIdJsonConverter))]
-readonly partial struct TestShortId :
+public readonly partial struct TestShortId :
     ICreatableValueObject<short, TestShortId>,
     IParsableValueObject<TestShortId>,
     IValueObject<short, TestShortId>,
@@ -202,7 +202,7 @@ readonly partial struct TestShortId :
     }
 }
 
-public class TestShortIdTypeConverter : TypeConverter
+public sealed class TestShortIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -218,7 +218,7 @@ public class TestShortIdTypeConverter : TypeConverter
     }
 }
 
-public class TestShortIdJsonConverter : JsonConverter<TestShortId>
+public sealed class TestShortIdJsonConverter : JsonConverter<TestShortId>
 {
     public override void Write(Utf8JsonWriter writer, TestShortId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateShortIdentifier_WithoutNamespace.verified.txt

@@ -19,7 +19,7 @@ using LightResults.Extensions.ValueObjects;
 
 [TypeConverter(typeof(TestShortIdTypeConverter))]
 [JsonConverter(typeof(TestShortIdJsonConverter))]
-readonly partial struct TestShortId :
+public readonly partial struct TestShortId :
     ICreatableValueObject<short, TestShortId>,
     IParsableValueObject<TestShortId>,
     IValueObject<short, TestShortId>,
@@ -200,7 +200,7 @@ readonly partial struct TestShortId :
     }
 }
 
-public class TestShortIdTypeConverter : TypeConverter
+public sealed class TestShortIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -216,7 +216,7 @@ public class TestShortIdTypeConverter : TypeConverter
     }
 }
 
-public class TestShortIdJsonConverter : JsonConverter<TestShortId>
+public sealed class TestShortIdJsonConverter : JsonConverter<TestShortId>
 {
     public override void Write(Utf8JsonWriter writer, TestShortId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateStringIdentifier_WithNamespace.verified.txt

@@ -21,7 +21,7 @@ namespace MyProject.Identifiers;
 
 [TypeConverter(typeof(TestStringIdTypeConverter))]
 [JsonConverter(typeof(TestStringIdJsonConverter))]
-sealed partial class TestStringId :
+public sealed partial class TestStringId :
     ICreatableValueObject<string, TestStringId>,
     IValueObject<string, TestStringId>,
     IComparable<TestStringId>,
@@ -182,7 +182,7 @@ sealed partial class TestStringId :
     }
 }
 
-public class TestStringIdTypeConverter : TypeConverter
+public sealed class TestStringIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -198,7 +198,7 @@ public class TestStringIdTypeConverter : TypeConverter
     }
 }
 
-public class TestStringIdJsonConverter : JsonConverter<TestStringId>
+public sealed class TestStringIdJsonConverter : JsonConverter<TestStringId>
 {
     public override void Write(Utf8JsonWriter writer, TestStringId identifier, JsonSerializerOptions options)
     {

Diff for: tests/LightResults.Extensions.GeneratedIdentifier.Tests/GeneratedIdentifierSourceGeneratorTests.GenerateStringIdentifier_WithoutNamespace.verified.txt

@@ -19,7 +19,7 @@ using LightResults.Extensions.ValueObjects;
 
 [TypeConverter(typeof(TestStringIdTypeConverter))]
 [JsonConverter(typeof(TestStringIdJsonConverter))]
-sealed partial class TestStringId :
+public sealed partial class TestStringId :
     ICreatableValueObject<string, TestStringId>,
     IValueObject<string, TestStringId>,
     IComparable<TestStringId>,
@@ -180,7 +180,7 @@ sealed partial class TestStringId :
     }
 }
 
-public class TestStringIdTypeConverter : TypeConverter
+public sealed class TestStringIdTypeConverter : TypeConverter
 {
     public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
     {
@@ -196,7 +196,7 @@ public class TestStringIdTypeConverter : TypeConverter
     }
 }
 
-public class TestStringIdJsonConverter : JsonConverter<TestStringId>
+public sealed class TestStringIdJsonConverter : JsonConverter<TestStringId>
 {
     public override void Write(Utf8JsonWriter writer, TestStringId identifier, JsonSerializerOptions options)
     {