feat: collect test metrics (#651)

Author: MartinKolarik

src/lib/metrics.ts

@@ -80,9 +80,11 @@ export class MetricsAgent {
 		this.recordStats(`gp.measurement.time.${type}`, time);
 	}
 
-	recordMeasurement (type: string): void {
+	recordMeasurement (type: string, probeCount: number): void {
 		this.incrementCounter(`gp.measurement.count.${type}`);
 		this.incrementCounter('gp.measurement.count.total');
+		this.incrementCounter(`gp.test.count.${type}`, probeCount);
+		this.incrementCounter('gp.test.count.total', probeCount);
 	}
 
 	recordDisconnect (type: string): void {

src/measurement/runner.ts

@@ -37,12 +37,12 @@ export class MeasurementRunner {
 
 		if (onlineProbesMap.size) {
 			this.sendToProbes(measurementId, onlineProbesMap, request);
-			// If all selected probes are offline, immediately mark measurement as finished
+			// If all selected probes are offline, immediately mark the measurement as finished
 		} else {
 			await this.store.markFinished(measurementId);
 		}
 
-		this.metrics.recordMeasurement(request.type);
+		this.metrics.recordMeasurement(request.type, onlineProbesMap.size);
 
 		return { measurementId, probesCount: allProbes.length };
 	}

test/tests/unit/measurement/runner.test.ts

@@ -158,7 +158,7 @@ describe('MeasurementRunner', () => {
 		}]);
 
 		expect(metrics.recordMeasurement.callCount).to.equal(1);
-		expect(metrics.recordMeasurement.args[0]).to.deep.equal([ 'ping' ]);
+		expect(metrics.recordMeasurement.args[0]).to.deep.equal([ 'ping', 4 ]);
 	});
 
 	it('should send `inProgressUpdates: true` to the first N probes if requested', async () => {
@@ -258,7 +258,7 @@ describe('MeasurementRunner', () => {
 		}]);
 
 		expect(metrics.recordMeasurement.callCount).to.equal(1);
-		expect(metrics.recordMeasurement.args[0]).to.deep.equal([ 'ping' ]);
+		expect(metrics.recordMeasurement.args[0]).to.deep.equal([ 'ping', 4 ]);
 	});
 
 	it('should properly handle result events from probes', async () => {