Fixed issue in JS error comparison and updated JLE version

Author: codetiger

docs/index.html

@@ -23,7 +23,20 @@ export class TestRunner {
             if (!testCase.expectedError) {
                 return false;
             }
-            return this.compareErrors(error.message, testCase.expectedError);
+            if (Number.isNaN(error)) 
+                error = { type: 'NaN' }
+            else if (error.message) 
+                error = { type: error.message }
+
+            if (JSON.stringify(error) === JSON.stringify(testCase.expectedError) ) {
+                return true;
+            }
+
+            const success = this.compareErrors(error.type, testCase.expectedError);
+            if (!success) {
+                console.log('Result:', error);
+            }
+            return success;
         }
     }
 
@@ -63,19 +76,43 @@ export class TestRunner {
             return got.every((value, index) => this.compareValues(value, expected[index]));
         }
 
+        // Handle object comparisons
+        if (typeof got === 'object' && typeof expected === 'object') {
+            if (got === null || expected === null) {
+                return got === expected;
+            }
+            const gotKeys = Object.keys(got);
+            const expectedKeys = Object.keys(expected);
+            if (gotKeys.length !== expectedKeys.length) {
+                return false;
+            }
+            return gotKeys.every(key => 
+                expectedKeys.includes(key) && 
+                this.compareValues(got[key], expected[key])
+            );
+        }
+
         // Default strict comparison
         return got === expected;
     }
 
     compareErrors(got, expected) {
-        if (typeof expected !== 'object') {
+        console.log('compareErrors: got:', got);
+        console.log('expected:', expected.type);
+
+        if (!got || typeof expected !== 'object') {
             return false;
         }
+
+        if (expected.type === got || expected === got) {
+            return true;
+        }
 
-        const expectedType = expected.type?.toLowerCase() ?? '';
-        const expectedMessage = expected.message?.toLowerCase() ?? '';
+        const gotLower = got.toLowerCase();
+        const expectedType = expected?.type?.toLowerCase() ?? '';
+        const expectedMessage = expected?.message?.toLowerCase() ?? '';
 
-        return (!expectedType || got.toLowerCase().includes(expectedType)) &&
-               (!expectedMessage || got.toLowerCase().includes(expectedMessage));
+        return (!expectedType || gotLower.includes(expectedType)) &&
+               (!expectedMessage || gotLower.includes(expectedMessage));
     }
 }

js-tests/engines/TestRunner.js

@@ -34,8 +34,7 @@ async function runEngineSuite(engine, suite) {
         if (await runner.runTest(case_)) {
             passed++;
         } else {
-            console.log('Failed test case:', case_);
-            
+            console.log('Failed test case:', testCase);
         }
     }
 
@@ -53,7 +52,7 @@ async function main() {
         console.log(`Successfully loaded ${Object.keys(suites).length} test suites`);
 
         const summary = new TestSummary();
-        const engines = ['json-logic-js', 'json-logic-engine'];
+        const engines = ['json-logic-engine'];
 
         for (const [name, suite] of Object.entries(suites)) {
             console.log(`\nRunning suite: ${name}`);

js-tests/main.js

@@ -8,7 +8,7 @@
     "test": "node main.js"
   },
   "dependencies": {
-    "json-logic-engine": "^4.0.1",
+    "json-logic-engine": "^5.0.0-6",
     "json-logic-js": "^2.0.5"
   }
-}
+}

js-tests/package-lock.json

@@ -239,5 +239,5 @@
       "success_rate": 63.0457933972311
     }
   },
-  "timestamp": "2025-02-15T14:24:59.394922Z"
+  "timestamp": "2025-02-16T04:20:45.879302Z"
 }

js-tests/package.json

@@ -341,6 +341,6 @@
       "total": 939
     }
   },
-  "timestamp": "2025-02-15T14:24:54Z",
+  "timestamp": "2025-02-16T04:20:40Z",
   "go_version": "go1.23.0"
 }

results/csharp.json

@@ -239,5 +239,5 @@
       "success_rate" : 58.040468583599576
     }
   },
-  "timestamp" : "2025-02-15T14:24:58.505962Z"
+  "timestamp" : "2025-02-16T04:20:44.939676Z"
 }