Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve the readablity of text in Boolean reference page #1569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve the readablity of text in Boolean reference page #1569

wants to merge 1 commit into from

Conversation

Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Mar 19, 2025 •
edited
Loading

What kind of change does this PR introduce?
Improve the readablity of text in Boolean reference page.

Issue Number:
Closes #1564

Screenshots/videos:

image

If relevant, did you update the documentation?
No

Does this PR introduce a breaking change?
No

Checklist

@Adi-204 Adi-204 requested a review from a team as a code owner March 19, 2025 14:23
DarhkVoyd
DarhkVoyd requested changes Mar 23, 2025
View reviewed changes
Copy link
Member

@DarhkVoyd DarhkVoyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's increase the contrast even more, and use something like slate-200 or even white.

@Adi-204
Copy link
Contributor Author

Adi-204 commented Mar 23, 2025

@DarhkVoyd do you mean text-slate-200 and increase bg color? Can you please clarify

@DarhkVoyd
Copy link
Member

@DarhkVoyd do you mean text-slate-200 and increase bg color? Can you please clarify

I was referring to the text color. We could make it more legible by using either text-slate-200 or white.

@Adi-204
Copy link
Contributor Author

Adi-204 commented Mar 23, 2025 •
edited
Loading

@DarhkVoyd But then we need more darker bg color. I tried only text-slate-200 and text was not visible at all. The text written in back ticks will be visible but what about other words Thanks:)
image

@Adi-204
Copy link
Contributor Author

Adi-204 commented Mar 23, 2025 •
edited
Loading

@DarhkVoyd maybe we change the color of code part only

image

Should I proceed with above changes?

@DarhkVoyd
Copy link
Member

@DarhkVoyd maybe we change the color of code part only
Should I proceed with above changes?

If possible let's just do the inline-code block. What do you think DhairyaMajmudar, benjagm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarhkVoyd DarhkVoyd DarhkVoyd requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Readability issue in Boolean reference page
2 participants
@Adi-204 @DarhkVoyd