-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Change feedback form to actionable questions #841
docs: Change feedback form to actionable questions #841
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Hi @harshsbhat . The CI/CD workflow failed here: https://github.com/json-schema-org/website/actions/runs/10218752435/job/28275614951?pr=841 |
Also, the linked issue is tagged |
I am not very sure what is causing that error. Can you help me? I don't think it is from the file that I have edited |
Okay my bad. I won't start to work on something again without the APPROVAL/ASSIGNMENT for the same. So you want me to keep this PR or archive it? |
|
No worries, Harsh. Let's keep this PR for now. Someone from the web team will review it and provide guidance on how to proceed. |
Basically, the Codecov coverage token is not set up correctly, which is causing the job to fail. You don't need to do anything; the error is in the workflow configuration itself. |
Thanks a lot Alok for helping me out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the issue you grabbed this work from, this change needs to incorporate #762, but it doesn't appear to.
The thing is, we haven't made a decision on the direction for both of these issues together. We need to finalize that decision before work should be done.
To be specific, I don't think it's clear that "submit feedback" means they won't/can't be contacted about their feedback, while "create issue" means "I want to continue this conversation"/"I want more help".
Hi everyone. After losing the Postman accounts we have lost access to the airtable used to store the data. Moving forward we decided to use google sheets instead and we still need to implement the change. Can we hold this change until we are able to store the data again? |
@harshsbhat still available to work on this issue? We finally fixed the current feedback component to store data again so we can resume the work here and continue with the changes suggested on #762 . Happy to have a chat and work together on this. |
@benjagm |
Hi, @harshsbhat it seems like tests are failing and some merge conflicts are there can you pls. fix them |
Thanks for this contribution @harshsbhat . We are going to close this PR as there was no activity in the last 2 months. |
What kind of change does this PR introduce?
Improves the feedback form by adding actionable responses with options YES and NO rather than asking for a descriptive feedback.
Issue Number:
Screenshots/videos:
Summary