Skip to content

[Tests] fix CI install failures in after_install step#4009

Merged
ljharb merged 1 commit into
jsx-eslint:masterfrom
jonkoops:fix-ci-peer-deps
May 12, 2026
Merged

[Tests] fix CI install failures in after_install step#4009
ljharb merged 1 commit into
jsx-eslint:masterfrom
jonkoops:fix-ci-peer-deps

Conversation

@jonkoops

@jonkoops jonkoops commented May 12, 2026

Copy link
Copy Markdown
Contributor

Strip eslint-doc-generator from package.json before install where it causes peer dependency conflicts. It is only used for doc generation, not for running tests.

On Node < 6, its transitive dependency pretty-format@30.4.0 introduced npm: aliases unsupported by npm 5. On Node 16+ with strict peer resolution, its eslint >= 8.57.1 peer dep conflicts with the eslint@7 installed by after_install, causing npm's ERESOLVE diagnostic printer to intermittently crash.

Fixes #4007

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.63%. Comparing base (012ec39) to head (58ae639).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
+ Coverage   97.58%   97.63%   +0.04%     
==========================================
  Files         137      134       -3     
  Lines       10182    10170      -12     
  Branches     3795     3795              
==========================================
- Hits         9936     9929       -7     
+ Misses        246      241       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb

ljharb commented May 12, 2026

Copy link
Copy Markdown
Member

I'm fine with removing eslint-doc-generator in any workflow where it's a problem - but then why would --force be needed?

@jonkoops

Copy link
Copy Markdown
Contributor Author

Fair point, I originally fixed this issue partially by using --force, but then it still caused failures on older Node.js versions, so I proceeded applying a separate fix for that. If you don't mind just dropping the entire dependency for all conflicting parts of the matrix I will just drop the --force.

Strip `eslint-doc-generator` from `package.json` before install where it causes peer dependency conflicts.
It is only used for doc generation, not for running tests.

On Node < 6, its transitive dependency `pretty-format@30.4.0` introduced `npm:` aliases unsupported by npm 5.
On Node 16+ with strict peer resolution, its `eslint >= 8.57.1` peer dep conflicts with the `eslint@7` installed by `after_install`, causing npm's ERESOLVE diagnostic printer to intermittently crash.

Fixes jsx-eslint#4007

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@ljharb

ljharb commented May 12, 2026

Copy link
Copy Markdown
Member

That sounds good, thanks.

@jonkoops jonkoops force-pushed the fix-ci-peer-deps branch from 3ad9539 to 58ae639 Compare May 12, 2026 20:09
@ljharb ljharb force-pushed the fix-ci-peer-deps branch from 58ae639 to 09766f1 Compare May 12, 2026 20:57
@ljharb ljharb merged commit 09766f1 into jsx-eslint:master May 12, 2026
521 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Test matrix: ERESOLVE on (eslint 7, parser 6) cells under strict peer-deps

2 participants