[Tests] fix CI install failures in after_install step#4009
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4009 +/- ##
==========================================
+ Coverage 97.58% 97.63% +0.04%
==========================================
Files 137 134 -3
Lines 10182 10170 -12
Branches 3795 3795
==========================================
- Hits 9936 9929 -7
+ Misses 246 241 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I'm fine with removing eslint-doc-generator in any workflow where it's a problem - but then why would --force be needed? |
Contributor
Author
|
Fair point, I originally fixed this issue partially by using |
Strip `eslint-doc-generator` from `package.json` before install where it causes peer dependency conflicts. It is only used for doc generation, not for running tests. On Node < 6, its transitive dependency `pretty-format@30.4.0` introduced `npm:` aliases unsupported by npm 5. On Node 16+ with strict peer resolution, its `eslint >= 8.57.1` peer dep conflicts with the `eslint@7` installed by `after_install`, causing npm's ERESOLVE diagnostic printer to intermittently crash. Fixes jsx-eslint#4007 Signed-off-by: Jon Koops <jonkoops@gmail.com>
Member
|
That sounds good, thanks. |
3ad9539 to
58ae639
Compare
ljharb
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip
eslint-doc-generatorfrompackage.jsonbefore install where it causes peer dependency conflicts. It is only used for doc generation, not for running tests.On Node < 6, its transitive dependency
pretty-format@30.4.0introducednpm:aliases unsupported by npm 5. On Node 16+ with strict peer resolution, itseslint >= 8.57.1peer dep conflicts with theeslint@7installed byafter_install, causing npm's ERESOLVE diagnostic printer to intermittently crash.Fixes #4007