Do not embed reflect.Type to avoid supressing DCE (#73)

ikonst · web-flow · commit b9b849659044 · 2025-03-15T14:21:52.000-04:00
diff --git a/cache.go b/cache.go
@@ -42,7 +42,7 @@ func (fs fields) Less(i, j int) bool {
 
 type typeKey struct {
 	tag string
-	reflect.Type
+	typ reflect.Type
 }
 
 type fieldMap map[string]fields
@@ -92,7 +92,7 @@ func buildFields(k typeKey) fields {
 		tag
 	}
 
-	q := fields{{typ: k.Type}}
+	q := fields{{typ: k.typ}}
 	visited := make(map[key]struct{})
 	fm := make(fieldMap)
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func (fs fields) Less(i, j int) bool {`
`42`	`42`
`43`	`43`	`type typeKey struct {`
`44`	`44`	`tag string`
`45`		`- reflect.Type`
	`45`	`+ typ reflect.Type`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`type fieldMap map[string]fields`
`@@ -92,7 +92,7 @@ func buildFields(k typeKey) fields {`
`92`	`92`	`tag`
`93`	`93`	`}`
`94`	`94`
`95`		`- q := fields{{typ: k.Type}}`
	`95`	`+ q := fields{{typ: k.typ}}`
`96`	`96`	`visited := make(map[key]struct{})`
`97`	`97`	`fm := make(fieldMap)`
`98`	`98`