Skip to content

Commit b87b3d1

Browse files
committed
EA-5554: Bug fix for responders
1 parent 522f005 commit b87b3d1

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/Alert/CreateAlertRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function getBody(): array
5959
}
6060

6161
foreach ($this->alert->getResponders() as $responder) {
62-
$body['responders'] = [
62+
$body['responders'][] = [
6363
'id' => $responder->getId(),
6464
'type' => $responder->getType()
6565
];

tests/Alert/CreateAlertRequestTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,14 @@ public function testCanAppendResponder(): void
3838
{
3939
$alert = $this->createMock(Alert::class);
4040
$alert->expects($this->atLeastOnce())->method('getResponders')->willReturn([
41-
$this->createMock(Responder::class),
42-
$this->createMock(Responder::class)
41+
new Responder('foo', Responder::team),
42+
new Responder('bar', Responder::user),
4343
]);
4444
$request = new CreateAlertRequest($alert);
4545

4646
$this->assertArrayHasKey('responders', $request->getBody());
47+
$this->assertEquals(['id' => 'foo', 'type' => 'team'], $request->getBody()['responders'][0]);
48+
$this->assertEquals(['id' => 'bar', 'type' => 'user'], $request->getBody()['responders'][1]);
4749
}
4850

4951
public function testCanAppendTags(): void

0 commit comments

Comments
 (0)