Drop Python 3.6, update to ipywidgets 8 (#100)

* Add gitpod

* Fix conda install

* Add develop command

* Drop Python 3.6

* Support ipywidgets 8

* Update to ipywidgets 8

* Fix ESLint

* Try fixing macos on CI

* Revert py_cmd changes

* Update to `actions/setup-python@v4`

* Try with 3.8

* Try special case macos

* Switch back to 3.7

* fix if

* Remove custom step

* try with custom pip_cmd

* try pip3

* Switch to `bash -e`

Author: jtpio

.eslintrc.js

@@ -3,24 +3,28 @@ module.exports = {
     'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
-    'plugin:jsdoc/recommended',
     'plugin:prettier/recommended',
-    'plugin:react/recommended',
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
+    project: 'tsconfig.json',
     sourceType: 'module',
-    ecmaVersion: 2017,
   },
-  plugins: ['@typescript-eslint', 'jsdoc'],
+  plugins: ['@typescript-eslint'],
   rules: {
-    '@typescript-eslint/interface-name-prefix': [
+    '@typescript-eslint/naming-convention': [
       'error',
-      { prefixWithI: 'always' },
+      {
+        selector: 'interface',
+        format: ['PascalCase'],
+        custom: {
+          regex: '^I[A-Z]',
+          match: true,
+        },
+      },
     ],
     '@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/camelcase': 'off',
     '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/quotes': [
@@ -29,19 +33,7 @@ module.exports = {
       { avoidEscape: true, allowTemplateLiterals: false },
     ],
     curly: ['error', 'all'],
-    'jsdoc/require-param-type': 'off',
-    'jsdoc/require-property-type': 'off',
-    'jsdoc/require-returns-type': 'off',
-    'jsdoc/require-returns': 'off',
-    'jsdoc/no-types': 'warn',
+    eqeqeq: 'error',
     'prefer-arrow-callback': 'error',
   },
-  settings: {
-    jsdoc: {
-      mode: 'typescript',
-    },
-    react: {
-      version: 'detect',
-    },
-  },
 };

.github/workflows/build.yml

@@ -18,9 +18,9 @@ jobs:
       with:
        node-version: '14.x'
     - name: Install Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
-        python-version: '3.9'
+        python-version: '3.10'
         architecture: 'x64'
     - name: Install dependencies
       run: |

.github/workflows/check-release.yml

@@ -17,9 +17,9 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
       - name: Install Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
-          python-version: 3.9
+          python-version: '3.10'
           architecture: 'x64'
       - name: Install node
         uses: actions/setup-node@v2

.github/workflows/lint.yml

@@ -17,9 +17,9 @@ jobs:
       with:
        node-version: '14.x'
     - name: Install Python
-      uses: actions/setup-python@v1
+      uses: actions/setup-python@v4
       with:
-        python-version: '3.9'
+        python-version: '3.10'
         architecture: 'x64'
     - name: Install JupyterLab
       run: python -m pip install jupyterlab
@@ -34,9 +34,9 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v1
     - name: Install Python
-      uses: actions/setup-python@v1
+      uses: actions/setup-python@v4
       with:
-        python-version: '3.9'
+        python-version: '3.10'
         architecture: 'x64'
     - name: Install black
       run: python -m pip install black

.github/workflows/packaging.yml

@@ -11,7 +11,7 @@ env:
 
 defaults:
   run:
-    shell: bash -l {0}
+    shell: bash -e {0}
 
 jobs:
   build:
@@ -24,9 +24,9 @@ jobs:
       with:
        node-version: '14.x'
     - name: Install Python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
-        python-version: '3.9'
+        python-version: '3.10'
         architecture: 'x64'
     - name: Install dependencies
       run: |
@@ -56,22 +56,25 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu, macos, windows]
-        python: ['3.6', '3.9']
+        python: ['3.7', '3.10']
         include:
-          - python: '3.6'
+          - python: '3.7'
             dist: 'ipylab*.tar.gz'
-          - python: '3.9'
+          - python: '3.10'
             dist: 'ipylab*.whl'
           - os: windows
             py_cmd: python
+            pip_cmd: python -m pip
           - os: macos
             py_cmd: python3
+            pip_cmd: pip3
           - os: ubuntu
             py_cmd: python
+            pip_cmd: python -m pip
 
     steps:
       - name: Install Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python }}
           architecture: 'x64'
@@ -81,15 +84,15 @@ jobs:
           path: ./dist
       - name: Install the prerequisites
         run: |
-          ${{ matrix.py_cmd }} -m pip install --upgrade pip wheel jupyterlab~=3.0
+          ${{ matrix.pip_cmd }} install --upgrade pip wheel jupyterlab~=3.0
       - name: Install the package
         run: |
           cd dist
-          ${{ matrix.py_cmd }} -m pip install -vv ${{ matrix.dist }}
+          ${{ matrix.pip_cmd }} install -vv ${{ matrix.dist }}
       - name: Validate environment
         run: |
-          ${{ matrix.py_cmd }} -m pip freeze
-          ${{ matrix.py_cmd }} -m pip check
+          ${{ matrix.pip_cmd }} freeze
+          ${{ matrix.pip_cmd }} check
       - name: Validate the install
         run: |
           jupyter labextension list

.gitpod.yml

@@ -0,0 +1,41 @@
+github:
+  prebuilds:
+    master: true
+    pullRequests: true
+    pullRequestsFromForks: true
+    addCheck: false
+    addComment: false
+    addBadge: false
+    addLabel: false
+tasks:
+  - name: setup
+    init: |
+      pushd /workspace
+      wget -qO- https://micro.mamba.pm/api/micromamba/linux-64/latest | tar -xvj bin/micromamba
+      popd
+      # bootstrap activation commands for other tasks to reuse
+      cat <<EOT > /workspace/bin/activate-env.sh
+      export MAMBA_ROOT_PREFIX=/workspace/.micromamba
+      export MAMBA_EXE=/workspace/bin/micromamba
+      $(/workspace/bin/micromamba shell hook --shell=bash)
+      micromamba config append channels conda-forge
+      export JUPYTER_PREFER_ENV_PATH=1
+      micromamba activate
+      EOT
+      source /workspace/bin/activate-env.sh
+      micromamba install -n base -y python=3.10 nodejs=14 jupyterlab=3 yarn
+      python -m pip install -e ".[dev,test]" && jlpm && jlpm run build && jupyter labextension develop . --overwrite
+      gp sync-done setup
+    command: |
+      gp sync-done setup
+      source /workspace/bin/activate-env.sh
+      jupyter lab --no-browser --LabApp.token='' --LabApp.allow_origin=* --LabApp.tornado_settings='{"headers": {"Content-Security-Policy": "frame-ancestors *"}}'
+
+  - name: watch
+    command: |
+      gp sync-await setup
+      source /workspace/bin/activate-env.sh
+      jlpm watch
+
+ports:
+  - port: 8888

package.json

@@ -70,37 +70,37 @@
     ]
   },
   "dependencies": {
-    "@jupyter-widgets/base": "^1 || ^2 || ^3 || ^4",
-    "@jupyter-widgets/controls": "^3.0.0",
-    "@jupyterlab/application": "^3.2.3",
-    "@jupyterlab/apputils": "^3.2.3",
-    "@jupyterlab/observables": "^4.2.3",
-    "@lumino/algorithm": "^1.9.1",
-    "@lumino/commands": "^1.12.0",
-    "@lumino/disposable": "^1.10.1",
-    "@lumino/messaging": "^1.10.1",
-    "@lumino/widgets": "^1.30.0"
+    "@jupyter-widgets/base": "^1 || ^2 || ^3 || ^4 || ^5 || ^6",
+    "@jupyter-widgets/controls": "^3 || ^4 || ^5",
+    "@jupyterlab/application": "^3.4.5",
+    "@jupyterlab/apputils": "^3.4.5",
+    "@jupyterlab/observables": "^4.4.5",
+    "@lumino/algorithm": "^1.9.2",
+    "@lumino/commands": "^1.20.1",
+    "@lumino/disposable": "^1.10.2",
+    "@lumino/messaging": "^1.10.2",
+    "@lumino/widgets": "^1.34.0"
   },
   "devDependencies": {
-    "@jupyterlab/builder": "^3.2.3",
+    "@jupyterlab/builder": "^3.4.5",
     "@types/expect.js": "^0.3.29",
-    "@types/node": "^10.11.6",
-    "@typescript-eslint/eslint-plugin": "^2.26.0",
-    "@typescript-eslint/parser": "^2.26.0",
-    "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.10.1",
-    "eslint-plugin-jsdoc": "^22.1.0",
-    "eslint-plugin-prettier": "^3.1.2",
-    "eslint-plugin-react": "^7.18.3",
+    "@types/node": "^18.7.8",
+    "@typescript-eslint/eslint-plugin": "^5.33.1",
+    "@typescript-eslint/parser": "^5.33.1",
+    "eslint": "^8.22.0",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-plugin-jsdoc": "^39.3.6",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-react": "^7.30.1",
     "expect.js": "^0.3.1",
-    "fs-extra": "^7.0.0",
-    "husky": "^3.1.0",
-    "lint-staged": "^9.4.3",
-    "mkdirp": "^0.5.1",
-    "npm-run-all": "^4.1.3",
-    "prettier": "^2.0.2",
-    "rimraf": "^2.6.2",
-    "typescript": "~4.4.4"
+    "fs-extra": "^10.1.0",
+    "husky": "^8.0.1",
+    "lint-staged": "^13.0.3",
+    "mkdirp": "^1.0.4",
+    "npm-run-all": "^4.1.5",
+    "prettier": "^2.7.1",
+    "rimraf": "^3.0.2",
+    "typescript": "~4.7.4"
   },
   "jupyterlab": {
     "extension": "lib/plugin",

setup.cfg

@@ -14,10 +14,10 @@ classifiers =
     License :: OSI Approved :: BSD License
     Programming Language :: Python
     Programming Language :: Python :: 3
-    Programming Language :: Python :: 3.6
     Programming Language :: Python :: 3.7
     Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
+    Programming Language :: Python :: 3.10
     Framework :: Jupyter
     Framework :: Jupyter :: JupyterLab
     Framework :: Jupyter :: JupyterLab :: 3
@@ -28,9 +28,9 @@ classifiers =
 zip_safe = False
 include_package_data = True
 packages = find:
-python_requires = >=3.6
+python_requires = >=3.7
 install_requires =
-    ipywidgets>=7.6.0,<8
+    ipywidgets>=7.6.0,<9
 
 [options.extras_require]
 test =

src/widgets/commands.ts

@@ -96,6 +96,8 @@ export class CommandRegistryModel extends WidgetModel {
    * Execute a command
    *
    * @param bundle The command bundle.
+   * @param bundle.id
+   * @param bundle.args
    */
   private _execute(bundle: {
     id: string;
@@ -143,6 +145,7 @@ export class CommandRegistryModel extends WidgetModel {
    * Remove a command from the command registry.
    *
    * @param bundle The command bundle.
+   * @param bundle.id
    */
   private _removeCommand(bundle: { id: string }): void {
     const { id } = bundle;

src/widgets/sessions.ts

@@ -79,7 +79,9 @@ export class SessionManagerModel extends WidgetModel {
    *
    * @param widget widget tracked by app.shell._track (FocusTracker)
    */
-  private _getSessionContext(widget: any): Session.IModel | {} {
+  private _getSessionContext(
+    widget: any
+  ): Session.IModel | Record<string, unknown> {
     return widget?.sessionContext?.session?.model ?? {};
   }
 
@@ -129,7 +131,7 @@ export class SessionManagerModel extends WidgetModel {
   static view_module: string = null;
   static view_module_version = MODULE_VERSION;
 
-  private _current_session: Session.IModel | {};
+  private _current_session: Session.IModel | Record<string, unknown>;
   private _sessions: SessionManager;
   static sessions: SessionManager;
   private _shell: JupyterFrontEnd.IShell;