Skip to content

Unexpected escape of fetch.ubuntu._run_with_retries without successfully finishing the command #743

Open
@addyess

Description

fetch.ubuntu._run_with_retries seems to escape without raising an exception in the event that the subprocess.check_call yields an exit code not in the list of retry_exitcode

this gives this method a false success when in reality it should fail immediately (no retrying)

i think the library method should raise when the exit value of subprocess.check_call is an error not on the rety list

TLDR:
if its exit value is 0 -- 🎉
if the exit value is in the retry_results -- retry max_retries like expected
if the exit value is not in the retry_results -- 🔥

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions