Open
Description
fetch.ubuntu._run_with_retries
seems to escape without raising an exception in the event that the subprocess.check_call
yields an exit code not in the list of retry_exitcode
this gives this method a false success when in reality it should fail immediately (no retrying)
i think the library method should raise when the exit value of subprocess.check_call
is an error not on the rety list
TLDR:
if its exit value is 0 -- 🎉
if the exit value is in the retry_results
-- retry max_retries like expected
if the exit value is not in the retry_results
-- 🔥
Metadata
Assignees
Labels
No labels
Activity