Commit a05c314
authored
Merge pull request #1258 from gboutry/fix/machine-addresses-hint
#1258
#### Description
Having `list[str]` has type-hinting made working with a type-checker awkward as an addresses is defined as a dict of mostly [str, str] key-values pairs, with one key-value being a [str, boolean] key-value pairs.
#### QA Steps
Just a type hint change
#### Notes & Discussion
I chose not to type as `typing.List[typing.Dict[str, typing.Union[str, boolean]]]` as it would make working with that type also awkward...
https://github.com/juju/python-libjuju/blob/fdbbbe9ccbbeb596fc500fdf6225ea937856f507/juju/client/schemas-juju-3.6.0.json#L105861 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
230 | | - | |
| 230 | + | |
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
| |||
0 commit comments