sema: fix when the builtin append function used with incompatible types such as (dest=[]str,src=[][]str...), runtime implementation instantiated and relevant internal implementation error will show up along with the type error

Author: mertcandav

std/jule/sema/builtin.jule

@@ -551,16 +551,9 @@ fn builtinCallerAppend(mut e: &eval, mut fc: &ast::CallExpr, mut v: &Value): &Va
 			ret nil
 		}
 
-		if e.s.meta.runtime != nil {
-			// Add instance to relevant runtime function for slice type if not exist.
-			mut f := runtimeFindFunc(e.s.meta.runtime, "memappend").instanceForce()
-			f.Generics = append(f.Generics, &InsGeneric{Type: t.Type}, &InsGeneric{Type: e1.Type})
-			ok, _ := e.s.checkGenericFunc(&f, fc.Token)
-			if !ok {
-				panic("sema: memappend evaluation failed, this is an implementation mistake")
-			}
-			e.pushReference(f)
-		}
+		// Save the type of e1.
+		mut e1typ := e1.Type
+
 		// Source should use the same type with destination.
 		// So, to make e1 unvariadic, use type of the destination.
 		mut elems := new(Value, *e1)
@@ -575,16 +568,31 @@ fn builtinCallerAppend(mut e: &eval, mut fc: &ast::CallExpr, mut v: &Value): &Va
 		// Before the analysis, set variadic kind as not variadic.
 		// This is should be made to avoid mutability error for base type of slice.
 		// Element types should still be checked.
-		// Since the variadiced slice will not mutated, just check mutability risk of elements.
+		// Since the variadiced slice will not be mutated,
+		// just check mutability risk of elements.
 		e1.Type.Variadic = false
 
 		if e.s.checkValidityForInitExpr(mutable, reference, s.Value, e1, secondArg.Token) {
 			e1.Type.Variadic = true
 			// Check type if validity is good.
 			// Helps to reduce error logs and duplicated logs.
-			_ = e.s.checkAssignType(reference, firstAssignToDest, s.Value, e1, secondArg.Token, e.getOwnerRefers())
+			if !e.s.checkAssignType(reference, firstAssignToDest, s.Value, e1, secondArg.Token, e.getOwnerRefers()) {
+				ret nil
+			}
 		} else {
 			e1.Type.Variadic = true
+			ret nil
+		}
+
+		if e.s.meta.runtime != nil {
+			// Add instance to relevant runtime function for slice type if not exist.
+			mut f := runtimeFindFunc(e.s.meta.runtime, "memappend").instanceForce()
+			f.Generics = append(f.Generics, &InsGeneric{Type: t.Type}, &InsGeneric{Type: e1typ})
+			ok, _ := e.s.checkGenericFunc(&f, fc.Token)
+			if !ok {
+				panic("sema: memappend evaluation failed, this is an implementation mistake")
+			}
+			e.pushReference(f)
 		}
 
 		ret v
@@ -606,7 +614,11 @@ fn builtinCallerAppend(mut e: &eval, mut fc: &ast::CallExpr, mut v: &Value): &Va
 		if e.s.checkValidityForInitExpr(mutable, reference, s.Value, e1, arg.Token) {
 			// Check type if validity is good.
 			// Helps to reduce error logs and duplicated logs.
-			_ = e.s.checkAssignType(reference, firstAssignToDest, s.Value, e1, arg.Token, e.getOwnerRefers())
+			if !e.s.checkAssignType(reference, firstAssignToDest, s.Value, e1, arg.Token, e.getOwnerRefers()) {
+				ret nil
+			}
+		} else {
+			ret nil
 		}
 		slice.Elems = append(slice.Elems, e1)
 	}