-
-
Notifications
You must be signed in to change notification settings - Fork 39
Description
In the current implementation, the library's AndroidManifest.xml contains all permissions required by the library to function properly. That is good, but now the users do not have the flexibility to remove any permissions they do not need. For example, I do not want FINE_LOCATION and COARSE_LOCATION permissions on Android 12 and above since they are not a hard requirement anymore because I can assert that I don't need the location permissions by using android:usesPermissionFlags="neverForLocation".
But the library still forces me to have these permissions in my merged manifest. So, if I try to override the permissions by using tools:maxSdkVersion=30, it not only does not work but also causes the Play Store console to throw the following issues when I try to upload an APK or AAB:
Duplicate declarations of permission android.permission.ACCESS_FINE_LOCATION with different maxSdkVersions
Duplicate declarations of permission android.permission.ACCESS_COARSE_LOCATION with different maxSdkVersions
Therefore, I request that we please remove all permissions from the library's AndroidManifest.xml and update the README to instead guide the users to add in only the permissions they require. I am happy to lend a hand and raise a PR if it is acceptable, do let me know.
Temporary Workaround
Just in case someone is trying to find a temporary solution/workaround for this Google Play Store issue, you can follow this solution:
In this case, the selector would be dev.steenbakker.nordicdfu

