Also remove Web Push subscription on token revocation by origin for

mobile scope. This is because the mobile app can use Unified Push.

Author: julien4215

app/controllers/OAuth.scala

@@ -111,7 +111,12 @@ final class OAuth(env: Env, apiC: => Api) extends LilaController(env):
   def revokeClient = AuthBody { ctx ?=> _ ?=>
     bindForm(lila.oauth.AccessTokenRequest.revokeClientForm)(
       _ => BadRequest,
-      origin => env.oAuth.tokenApi.revokeByClientOrigin(origin).inject(NoContent)
+      origin =>
+        for
+          tokens <- env.oAuth.tokenApi.revokeByClientOrigin(origin)
+          _      <- ctx.isMobileOauth.soFu:
+            tokens.traverse(token => env.push.webSubscriptionApi.unsubscribeBySession(token.value))
+        yield NoContent
     )
   }
 

modules/oauth/src/main/AccessTokenApi.scala

@@ -176,26 +176,29 @@ final class AccessTokenApi(
       .runWith(Sink.ignore)
       .void
 
-  def revokeByClientOrigin(clientOrigin: String)(using me: MyId): Funit =
-    coll
-      .find(
-        $doc(
-          F.userId       -> me,
-          F.clientOrigin -> clientOrigin
-        ),
-        $doc(F.id -> 1).some
-      )
-      .sort($sort.desc(F.usedAt))
-      .cursor[Bdoc]()
-      .list(100)
-      .flatMap: invalidate =>
-        coll.delete
-          .one:
-            $doc(
-              F.userId       -> me,
-              F.clientOrigin -> clientOrigin
-            )
-          .map(_ => invalidate.flatMap(_.getAsOpt[AccessToken.Id](F.id)).foreach(onRevoke))
+  def revokeByClientOrigin(clientOrigin: String)(using me: MyId): Fu[List[AccessToken.Id]] =
+    for
+      tokens <- coll
+        .find(
+          $doc(
+            F.userId       -> me,
+            F.clientOrigin -> clientOrigin
+          ),
+          $doc(F.id -> 1).some
+        )
+        .sort($sort.desc(F.usedAt))
+        .cursor[Bdoc]()
+        .list(100)
+        .flatMap: invalidate =>
+          coll.delete
+            .one:
+              $doc(
+                F.userId       -> me,
+                F.clientOrigin -> clientOrigin
+              )
+            .map(_ => invalidate.flatMap(_.getAsOpt[AccessToken.Id](F.id)))
+      _ = tokens.foreach(onRevoke(_))
+    yield tokens
 
   def revoke(bearer: Bearer) =
     val id = AccessToken.Id.from(bearer)