Skip to content

Refactor JWT handling + Bump min PHP version #484

@samuelwei

Description

@samuelwei

This library currently lacks many tests, especially for validating signed/encrypted JWT.
Constructing JWTs for tests is complex to test if the custom JWT paring and validation is correct.

It can also be seen from the amount of PR I have created in the last few days that the current JWT claim handling is missing some key validations.

My recommendation is to replace the current JWT handling with the external libaray https://web-token.spomky-labs.com/
This external library requires PHP 8.1 or higher.

At the same time, it would make sense to bump the minimum PHP version of the library to PHP 8.1 as well, since all previous PHP versions are EOL.

Image

This would be a major change, but I think it might be necessary if the goal is to make this library OpenID Connect specification compliant and secure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions