Skip to content

Commit f0fde61

Browse files
authored
fix: spindl feature cards display (#2842)
1 parent e5b6d8f commit f0fde61

3 files changed

Lines changed: 6 additions & 15 deletions

File tree

src/components/FeatureCards/FeatureCard.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ export const FeatureCard = ({ data }: FeatureCardProps) => {
3838
const imageUrl = useFeatureCardImage(data);
3939
const colors = useFeatureCardColors(data, imageUrl);
4040
const cardStyles = useFeatureCardStyles();
41-
const { trackDisplay, trackClose, trackClick } = useFeatureCardTracking(data);
41+
const { trackDisplay, trackClose, trackClick, trackImpression } =
42+
useFeatureCardTracking(data);
4243
const { disableCard } = useFeatureCardDisable(data);
4344

4445
const walletAddress = account?.address ?? '';
@@ -68,6 +69,7 @@ export const FeatureCard = ({ data }: FeatureCardProps) => {
6869
const handleImpressionOnce = () => {
6970
if (open) {
7071
trackDisplay();
72+
trackImpression();
7173
}
7274
};
7375

src/components/FeatureCards/hooks.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ export const useFeatureCardTracking = (data: FeatureCardData) => {
2525
const impressionEventFired = useRef(false);
2626
const displayEventFired = useRef(false);
2727

28-
// Track Spindl impression on mount
29-
useEffect(() => {
28+
const trackImpression = () => {
3029
if (impressionEventFired.current) {
3130
return;
3231
}
@@ -39,7 +38,7 @@ export const useFeatureCardTracking = (data: FeatureCardData) => {
3938
data.spindlData.ad_creative_id,
4039
);
4140
}
42-
}, [data]);
41+
};
4342

4443
const trackDisplay = () => {
4544
if (displayEventFired.current) {
@@ -93,7 +92,7 @@ export const useFeatureCardTracking = (data: FeatureCardData) => {
9392
}
9493
};
9594

96-
return { trackDisplay, trackClose, trackClick };
95+
return { trackDisplay, trackImpression, trackClose, trackClick };
9796
};
9897

9998
export const useFeatureCardColors = (

src/hooks/feature-cards/spindl/useSpindlCards.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,8 @@ export const useSpindlCards = () => {
2525
const spindlConfig = getSpindlConfig();
2626
const { fetchData } = useCallRequest();
2727

28-
// Feature Flag logic: Show Spindl for ~30% of users
29-
const showSpindle = useMemo(() => {
30-
return Math.random() < 0.3;
31-
}, []);
32-
3328
const fetchSpindlData = useCallback(
3429
async ({ country, chainId, tokenAddress, address }: SpindlFetchParams) => {
35-
if (!showSpindle) {
36-
// console.log('User is not part of the Spindl A/B test group.');
37-
return; // Exit early if the user is not in the A/B test group
38-
}
39-
4030
const locale = getLocale().split('-');
4131
const queryParams: Record<string, string | undefined> = {
4232
placement_id: 'notify_message',

0 commit comments

Comments
 (0)