Skip to content

Commit 0962845

Browse files
committed
fix(k8s): hide the empty placeholder while connecting
1 parent 66b9268 commit 0962845

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

‎ui/koko/tests/kubernetes/kubernetesWorkspace.test.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ describe("kubernetes workspace click typing", () => {
77
expect(kubernetesWorkspace).toContain('@click="void (resourceTreeOpen = true)"');
88
});
99

10+
it("hides the idle empty placeholder while the connection progress overlay is showing", () => {
11+
expect(kubernetesWorkspace).toContain('v-if="!terminalTabs.length && !connectingOverlay"');
12+
expect(kubernetesWorkspace).toContain("koko.kubernetes.empty");
13+
});
14+
1015
it("keeps the themed terminal edge-to-edge with FitAddon-aware text spacing", () => {
1116
expect(kubernetesWorkspace).toMatch(
1217
/\.kubernetes-terminal :deep\(\.terminal\)\s*\{[^}]*height:\s*100%;[^}]*padding:\s*8px 2px 4px 8px;/

‎ui/koko/workspaces/KubernetesWorkspace.vue‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ let resizeHandle: HTMLElement | null = null;
112112
let resizePointerId: number | null = null;
113113
const terminalSocket = useKubernetesTerminalSocket();
114114
115+
const connectingOverlay = computed(() => Boolean((tab.value as { connectionProgress?: string }).connectionProgress));
115116
const activeTab = computed(() => terminalTabs.value.find((item) => item.id === activeTabId.value) || null);
116117
const assetName = computed(() => tab.value.assetName || t("koko.kubernetes.name"));
117118
const resize = useDebounceFn(() => {
@@ -826,7 +827,10 @@ onUnmounted(() => {
826827
class="kubernetes-terminal absolute inset-0"
827828
:class="activeTabId === item.id ? '' : 'pointer-events-none invisible'"
828829
/>
829-
<div v-if="!terminalTabs.length" class="grid h-full place-items-center p-6 text-sm text-(--app-muted)">
830+
<div
831+
v-if="!terminalTabs.length && !connectingOverlay"
832+
class="grid h-full place-items-center p-6 text-sm text-(--app-muted)"
833+
>
830834
<div class="flex flex-col items-center gap-3">
831835
<UIcon name="i-lucide-square-terminal" class="size-10" />
832836
<span>{{ t("koko.kubernetes.empty") }}</span>

0 commit comments

Comments
 (0)