fix: right panel sftp

Author: ZhaoJiSen

ui/components/RightPanel/sftpPanel.vue

@@ -45,16 +45,20 @@ const panesById = computed(() => {
   }
   return panes;
 });
+// Every live pane is listed, including ones with no resolvable identity yet, so
+// the cache can tell "pane closed" from "details not loaded on this tick".
 const liveIdentities = computed(() => {
   const identities = new Map<string, string>();
   for (const [paneId, surface] of panesById.value) {
-    const identity = compactSftpCacheIdentity({
+    identities.set(
       paneId,
-      protocol: surface.protocol,
-      assetId: surface.assetId,
-      account: surface.account
-    });
-    if (identity) identities.set(paneId, identity);
+      compactSftpCacheIdentity({
+        paneId,
+        protocol: surface.protocol,
+        assetId: surface.assetId,
+        account: surface.account
+      })
+    );
   }
   return identities;
 });

ui/components/RightPanel/sftpSessionCache.test.ts

@@ -102,6 +102,17 @@ describe("nextSftpSessionCache", () => {
     expect(next).toEqual([]);
   });
 
+  it("keeps the surface while a live pane has no resolved identity", () => {
+    const next = nextSftpSessionCache({
+      cached: [{ paneId: paneA, identity: identityA }],
+      identities: new Map([[paneA, ""]]),
+      activePaneId: paneA,
+      activeReady: true,
+      sftpTabVisible: true
+    });
+    expect(next).toEqual([{ paneId: paneA, identity: identityA }]);
+  });
+
   it("drops a closed pane", () => {
     const next = nextSftpSessionCache({
       cached: [
@@ -150,7 +161,7 @@ describe("nextSftpSessionCache", () => {
     expect(next).toEqual([]);
   });
 
-  it("does not cache a non-SSH or missing pane", () => {
+  it("does not cache a non-SSH or unresolved pane", () => {
     expect(
       nextSftpSessionCache({
         cached: [],

ui/components/RightPanel/sftpSessionCache.ts

@@ -21,13 +21,22 @@ export function compactSftpCacheIdentity(input: {
 /** ponytail: no LRU; bound is SSH panes that opened SFTP. */
 export function nextSftpSessionCache(input: {
   cached: CachedSftpPane[];
+  /** Every live pane, including ones whose identity is not resolved yet. */
   identities: Map<string, string>;
   activePaneId: string;
   /** The koko session must exist before a surface can be created, never to keep one. */
   activeReady: boolean;
   sftpTabVisible: boolean;
 }): CachedSftpPane[] {
-  const retained = input.cached.filter((entry) => input.identities.get(entry.paneId) === entry.identity);
+  const retained = input.cached.filter((entry) => {
+    // Pane closed.
+    if (!input.identities.has(entry.paneId)) return false;
+    const identity = input.identities.get(entry.paneId) || "";
+    // Identity not resolved on this tick; keep the surface rather than
+    // rebuilding it, which would drop the websocket and any transfer.
+    if (!identity) return true;
+    return identity === entry.identity;
+  });
   if (!input.sftpTabVisible || !input.activeReady) return retained;
   const identity = input.identities.get(input.activePaneId) || "";
   if (!identity || retained.some((entry) => entry.paneId === input.activePaneId)) return retained;

ui/layouts/default.vue

@@ -34,6 +34,17 @@ const {
   statusBarVisible
 } = useSettingManager();
 const { open: rightPanelOpen, toggle: toggleRightPanel } = useRightPanel();
+// Mount on first open, then keep mounted. Unmounting the panel tears down its
+// KeepAlive cache, which drops the SFTP file manager's websocket and restarts
+// any transfer running in it.
+const rightPanelMounted = ref(false);
+watch(
+  rightPanelOpen,
+  (open) => {
+    if (open) rightPanelMounted.value = true;
+  },
+  { immediate: true }
+);
 const { open: aiPanelOpen, setOpen: setAiPanelOpen, toggleAi } = useAiPanel();
 const localePath = useLocalePath();
 const { open: settingsOpen, activeSection: activeSettingsSection, openSettings, closeSettings } = useSettingsWindow();
@@ -407,7 +418,7 @@ onBeforeUnmount(() => {
 
       <template #rightPanel>
         <div v-if="isVideoPlayerRoute" id="offline-playlist-host" class="h-full min-h-0" />
-        <RightPanel v-else-if="rightPanelOpen" />
+        <RightPanel v-else-if="rightPanelMounted" v-show="rightPanelOpen" />
       </template>
 
       <template #bottomPanel>