fix(windows): repair packaging and align installer defaults

Author: ibuler

applets/weblite/scripts/package.mjs

@@ -56,13 +56,14 @@ try {
     version: manifest.version,
     exe: "weblite.exe",
     icon: path.join(root, "assets/icon.ico"),
-    programFilesFolderName: "Weblite",
+    programFilesFolderName: "WebLite",
     nestedFolderName: "JumpServer",
     shortName: "WebLite",
     shortcutFolderName: "JumpServer",
     appUserModelId: "com.jumpserver.weblite",
     arch: "x64",
     defaultInstallMode: "perMachine",
+    ui: { chooseDirectory: true },
     // Keep this stable so Windows Installer upgrades the existing deployment.
     upgradeCode: "BBB88A37-4470-4B1C-B582-EAE84A775985"
   });

electron/assets/installer.nsh

@@ -0,0 +1,5 @@
+; Use the standard install-mode logic, including existing paths and /D overrides.
+!undef APP_FILENAME
+!define APP_FILENAME "JumpServer\Client"
+; Keep explicit app-data removal tied to the product rather than its install directory.
+!define /ifndef APP_PRODUCT_FILENAME "${PRODUCT_FILENAME}"

electron/forge.config.ts

@@ -219,6 +219,8 @@ const config: ForgeConfig = {
         },
         nsis: {
           oneClick: false,
+          selectPerMachineByDefault: true,
+          include: path.join(electronRoot, "assets", "installer.nsh"),
           allowToChangeInstallationDirectory: true,
           createDesktopShortcut: true,
           createStartMenuShortcut: true,
@@ -229,6 +231,7 @@ const config: ForgeConfig = {
       }
     }),
     new MakerWix({
+      defaultInstallMode: "perMachine",
       exe: `${executableName}.exe`,
       icon: path.join(iconsRoot, "icon.ico"),
       programFilesFolderName: "Client",

electron/tests/forge-artifacts.test.ts

@@ -1,5 +1,6 @@
 import type { ForgeConfig, ForgeMakeResult, ResolvedForgeConfig } from "@electron-forge/shared-types";
 import assert from "node:assert/strict";
+import { createRequire } from "node:module";
 import { mkdir, mkdtemp, readdir, readFile, rm, writeFile } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
@@ -11,6 +12,14 @@ import { MakerWix } from "@electron-forge/maker-wix";
 // Load the configuration with the same TypeScript loader used by Electron Forge.
 const configPromise = createJiti(import.meta.url).import<ForgeConfig>("../forge.config.ts", { default: true });
 
+test("NSIS builder resolves the download cache API required on clean machines", () => {
+  const require = createRequire(import.meta.url);
+  const builderRequire = createRequire(require.resolve("app-builder-lib"));
+  const { ElectronDownloadCacheMode, downloadArtifact } = builderRequire("@electron/get");
+  assert.equal(typeof ElectronDownloadCacheMode?.ReadWrite, "number");
+  assert.equal(typeof downloadArtifact, "function");
+});
+
 test("packaged clients claim jms2 without taking the legacy client's jms scheme", async () => {
   const config = await configPromise;
   assert.deepEqual(config.packagerConfig.protocols, [{ name: "JumpServer URL", schemes: ["jms2"] }]);
@@ -31,12 +40,18 @@ test("Windows installers provide a directory selection wizard and preserve the c
   assert.equal(options.win.executableName, config.packagerConfig.executableName);
   assert.deepEqual(options.protocols, config.packagerConfig.protocols);
   assert.equal(options.nsis.oneClick, false);
+  assert.equal(options.nsis.selectPerMachineByDefault, true);
+  const installerInclude = await readFile(options.nsis.include, "utf8");
+  assert.ok(installerInclude.includes('!define APP_FILENAME "JumpServer\\Client"'));
   assert.equal(options.nsis.allowToChangeInstallationDirectory, true);
   assert.equal(options.nsis.createDesktopShortcut, true);
   assert.equal(options.nsis.createStartMenuShortcut, true);
   assert.equal(options.nsis.runAfterFinish, true);
   assert.equal(options.nsis.deleteAppDataOnUninstall, false);
   assert.deepEqual(wix.config.ui, { chooseDirectory: true });
+  assert.equal(wix.config.defaultInstallMode, "perMachine");
+  assert.equal(wix.config.nestedFolderName, "JumpServer");
+  assert.equal(wix.config.programFilesFolderName, "Client");
 });
 
 test("normalizes release installer filenames", async (context) => {

package.json

@@ -8,7 +8,7 @@
   "author": "JumpServer",
   "license": "MIT",
   "engines": {
-    "node": ">=24"
+    "node": ">=22.19.0"
   },
   "scripts": {
     "dev": "pnpm electron:dev --web",

pnpm-lock.yaml

@@ -8,6 +8,8 @@ nodeLinker: hoisted
 
 overrides:
   "@electron/rebuild": 4.2.0
+  # builder 26.15.3 uses ElectronDownloadCacheMode, which @electron/get 3 does not export.
+  "app-builder-lib@26.15.3>@electron/get": 5.1.0
   cpu-features: "-"
 
 packages: