Test warning logs for CloseableResource without AutoCloseable

Issue #4434

Author: YongGoose

Diff for: junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/AbstractExtensionContext.java

@@ -35,6 +35,8 @@
 import org.junit.jupiter.engine.extension.ExtensionContextInternal;
 import org.junit.jupiter.engine.extension.ExtensionRegistry;
 import org.junit.platform.commons.JUnitException;
+import org.junit.platform.commons.logging.Logger;
+import org.junit.platform.commons.logging.LoggerFactory;
 import org.junit.platform.commons.util.Preconditions;
 import org.junit.platform.commons.util.UnrecoverableExceptions;
 import org.junit.platform.engine.EngineExecutionListener;
@@ -50,6 +52,8 @@
  */
 abstract class AbstractExtensionContext<T extends TestDescriptor> implements ExtensionContextInternal, AutoCloseable {
 
+	private static final Logger LOGGER = LoggerFactory.getLogger(AbstractExtensionContext.class);
+
 	private final ExtensionContext parent;
 	private final EngineExecutionListener engineExecutionListener;
 	private final T testDescriptor;
@@ -98,8 +102,8 @@ private NamespacedHierarchicalStore.CloseAction<org.junit.platform.engine.suppor
 
 			if (value instanceof Store.CloseableResource) {
 				if (isAutoCloseEnabled) {
-					engineExecutionListener.reportingEntryPublished(testDescriptor, ReportEntry.from("WARNING",
-						"Type implements CloseableResource but not AutoCloseable: " + value.getClass().getName()));
+					LOGGER.warn(
+						() -> "Type implements CloseableResource but not AutoCloseable: " + value.getClass().getName());
 				}
 				((Store.CloseableResource) value).close();
 			}

Diff for: jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ResourceAutoClosingTests.java

@@ -14,13 +14,17 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import java.util.logging.Level;
+import java.util.logging.LogRecord;
+
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.BeforeAllCallback;
-import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.jupiter.api.fixtures.TrackLogRecords;
 import org.junit.jupiter.engine.config.JupiterConfiguration;
 import org.junit.jupiter.engine.extension.ExtensionRegistry;
+import org.junit.platform.commons.logging.LogRecordListener;
 import org.junit.platform.launcher.core.NamespacedHierarchicalStoreProviders;
+import org.junit.platform.testkit.engine.ExecutionRecorder;
 
 class ResourceAutoClosingTests {
 
@@ -30,6 +34,7 @@ class ResourceAutoClosingTests {
 	private final LauncherStoreFacade launcherStoreFacade = new LauncherStoreFacade(
 		NamespacedHierarchicalStoreProviders.dummyNamespacedHierarchicalStore());
 
+	// TODO when config name is renamed, update the test name
 	@Test
 	void shouldCloseAutoCloseableWhenAutoCloseEnabledIsTrue() throws Exception {
 		AutoCloseableResource resource = new AutoCloseableResource();
@@ -60,6 +65,42 @@ void shouldNotCloseAutoCloseableWhenAutoCloseEnabledIsFalse() throws Exception {
 		assertThat(resource.closed).isFalse();
 	}
 
+	@Test
+	void shouldLogWarningWhenClosingResourceImplementsCloseableResourceButNotAutoCloseableAndConfigIsTrue(
+			@TrackLogRecords LogRecordListener listener) throws Exception {
+		ExecutionRecorder executionRecorder = new ExecutionRecorder();
+		CloseableResource resource = new CloseableResource();
+		String msg = "Type implements CloseableResource but not AutoCloseable: " + resource.getClass().getName();
+		when(configuration.isAutoCloseEnabled()).thenReturn(true);
+
+		ExtensionContext extensionContext = new JupiterEngineExtensionContext(executionRecorder, testDescriptor,
+			configuration, extensionRegistry, launcherStoreFacade);
+		ExtensionContext.Store store = extensionContext.getStore(ExtensionContext.Namespace.GLOBAL);
+		store.put("resource", resource);
+
+		((AutoCloseable) extensionContext).close();
+		assertThat(listener.stream(Level.WARNING)).map(LogRecord::getMessage).anyMatch(msg::equals);
+		assertThat(resource.closed).isTrue();
+	}
+
+	@Test
+	void shouldNotLogWarningWhenClosingResourceImplementsCloseableResourceAndAutoCloseableAndConfigIsFalse(
+			@TrackLogRecords LogRecordListener listener) throws Exception {
+		ExecutionRecorder executionRecorder = new ExecutionRecorder();
+		CloseableResource resource = new CloseableResource();
+		String msg = "Type implements CloseableResource but not AutoCloseable: " + resource.getClass().getName();
+		when(configuration.isAutoCloseEnabled()).thenReturn(false);
+
+		ExtensionContext extensionContext = new JupiterEngineExtensionContext(executionRecorder, testDescriptor,
+				configuration, extensionRegistry, launcherStoreFacade);
+		ExtensionContext.Store store = extensionContext.getStore(ExtensionContext.Namespace.GLOBAL);
+		store.put("resource", resource);
+
+		((AutoCloseable) extensionContext).close();
+		assertThat(listener.stream(Level.WARNING)).map(LogRecord::getMessage).noneMatch(msg::equals);
+		assertThat(resource.closed).isTrue();
+	}
+
 	static class AutoCloseableResource implements AutoCloseable {
 		private boolean closed = false;
 
@@ -69,19 +110,13 @@ public void close() {
 		}
 	}
 
-	static class AutoCloseableResourceStoreUsingExtension implements BeforeAllCallback {
-		@Override
-		public void beforeAll(ExtensionContext context) {
-			var store = context.getStore(ExtensionContext.Namespace.GLOBAL);
-			store.put("resource", new AutoCloseableResource());
-		}
-	}
+	@SuppressWarnings("deprecation")
+	static class CloseableResource implements ExtensionContext.Store.CloseableResource {
+		private boolean closed = false;
 
-	@SuppressWarnings("JUnitMalformedDeclaration")
-	@ExtendWith(AutoCloseableResourceStoreUsingExtension.class)
-	static class AutoCloseableTestCase {
-		@Test
-		void dummyTest() {
+		@Override
+		public void close() {
+			closed = true;
 		}
 	}
 }