Introduce feature flag for auto-closing `AutoCloseable` in Jupiter's ExtensionContext.Store #4452

YongGoose · 2025-04-06T14:12:44Z

Overview

fix #4434

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

There are no TODOs left in the code
Method preconditions are checked and documented in the method's Javadoc
Coding conventions (e.g. for logging) have been followed
Change is covered by automated tests including corner cases, errors, and exception handling
Public API has Javadoc and @API annotations
Change is documented in the User Guide and Release Notes

Issue junit-team#4434

jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ResourceAutoClosingTests.java

...piter-engine/src/main/java/org/junit/jupiter/engine/descriptor/AbstractExtensionContext.java

jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ResourceAutoClosingTests.java

jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/TestInstanceFactoryTests.java

jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ResourceAutoClosingTests.java

…r/ResourceAutoClosingTests.java Co-authored-by: Marc Philipp <[email protected]>

Issue junit-team#4434

documentation/src/docs/asciidoc/user-guide/extensions.adoc

...piter-api/src/main/java/org/junit/jupiter/api/extension/TestInstantiationAwareExtension.java

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/config/JupiterConfiguration.java

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java

junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedInvocationContext.java

...r-tests/src/test/java/org/junit/jupiter/api/extension/CloseableResourceIntegrationTests.java

jupiter-tests/src/test/java/org/junit/jupiter/engine/ClassTemplateInvocationTests.java

Issue junit-team#4434

junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ExtensionContext.java

...piter-engine/src/main/java/org/junit/jupiter/engine/descriptor/AbstractExtensionContext.java

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/execution/NamespaceAwareStore.java

...form-tooling-support-tests/src/test/java/platform/tooling/support/tests/ManagedResource.java

...ing-support-tests/src/test/java/platform/tooling/support/tests/OutputAttachingExtension.java

jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ResourceAutoClosingTests.java

documentation/src/test/java/example/extensions/HttpServerResource.java

…scriptor/AbstractExtensionContext.java Co-authored-by: Marc Philipp <[email protected]>

Issue junit-team#4434

…nfig/JupiterConfiguration.java Co-authored-by: Marc Philipp <[email protected]>

Issue junit-team#4434

marcphilipp · 2025-04-28T08:34:58Z

Thanks again, @YongGoose! 👍

YongGoose · 2025-04-28T11:19:59Z

Thanks again, @YongGoose! 👍

I'm very happy to have you back!
During the Easter holiday, I created a few issues and pull requests and left some comments.

Decide how to report 'unexpected' and 'actual' values in an exception #282
Enhance AssertionFailedError with negation context support ota4j-team/opentest4j#157
Provide an interface for collecting exceptions ota4j-team/opentest4j#3
Introduce ExceptionCollector Interface for Cross-Framework Exception Collection ota4j-team/opentest4j#162

I'd appreciate it if you could take a look and share your feedback whenever you have time. 😀

YongGoose · 2025-05-08T08:02:56Z

Thanks again, @YongGoose! 👍

I'm very happy to have you back! During the Easter holiday, I created a few issues and pull requests and left some comments.

Decide how to report 'unexpected' and 'actual' values in an exception #282

Enhance AssertionFailedError with negation context support ota4j-team/opentest4j#157

Provide an interface for collecting exceptions ota4j-team/opentest4j#3

Introduce ExceptionCollector Interface for Cross-Framework Exception Collection ota4j-team/opentest4j#162

I'd appreciate it if you could take a look and share your feedback whenever you have time. 😀

@marcphilipp

When you have time, I'd appreciate your feedback on the issue and PR!

marcphilipp · 2025-05-08T08:52:31Z

@YongGoose It's on my (growing) list to discuss with the team. I'll get back to you as soon as possible. Sorry for the delay!

YongGoose · 2025-05-08T09:22:18Z

@YongGoose It's on my (growing) list to discuss with the team. I'll get back to you as soon as possible. Sorry for the delay!

Thank you! I hope there’s not too much for the team to discuss… 🥹
And as always, thank you for all the work you do for the JUnit 5 community.

YongGoose · 2025-05-23T11:36:24Z

Hello @marcphilipp!!
Would it be okay to ask if the issue and PR mentioned in this comment fall within the scope of team meeting?

Introduce feature flag for auto-closing AutoCloseable in Jupiter's ExtensionContext.Store #4452 (comment)

marcphilipp · 2025-05-23T14:38:13Z

Sorry, those are still in the "discussion backlog". Sorry for making you wait! 😕

YongGoose · 2025-05-23T14:42:09Z

Sorry, those are still in the "discussion backlog". Sorry for making you wait! 😕

Not at all!

I recently became a committer for the apache/seata project, and I’m doing code reviews there based on the testing practices I learned while working with you.

Thanks to you, I’ve learned so much and achieved something meaningful.
Thank you! 🙇🏻

YongGoose added 3 commits April 6, 2025 16:30

Deprecate CloseableResource

5cf0a08

Issue junit-team#4434

Introduce configuration parameter

a524c83

Issue junit-team#4434

Log warning for CloseableResource without AutoCloseable

5c7b99e

Issue junit-team#4434

YongGoose force-pushed the feature/4434 branch from 2a428f8 to 66a1772 Compare April 6, 2025 14:19

Add tests

44dfb8a

Issue junit-team#4434

YongGoose force-pushed the feature/4434 branch from 66a1772 to 44dfb8a Compare April 6, 2025 14:19

YongGoose commented Apr 6, 2025

View reviewed changes

jupiter-tests/src/test/java/org/junit/jupiter/engine/descriptor/ResourceAutoClosingTests.java Show resolved Hide resolved

marcphilipp reviewed Apr 8, 2025

View reviewed changes

YongGoose and others added 6 commits April 9, 2025 21:28

Update jupiter-tests/src/test/java/org/junit/jupiter/engine/descripto…

0e22d7b

…r/ResourceAutoClosingTests.java Co-authored-by: Marc Philipp <[email protected]>

Merge branch 'main' into feature/4434

f52d0e0

Apply comments

35f25db

Issue junit-team#4434

Merge branch 'main' into feature/4434

8c6dbb3

Add documents

708af7d

Issue junit-team#4434

Replace warning-suppressed code with AutoCloseable usage

849492d

Issue junit-team#4434

YongGoose marked this pull request as ready for review April 9, 2025 14:18

YongGoose requested a review from marcphilipp April 9, 2025 14:19

YongGoose added 2 commits April 11, 2025 16:40

Merge branch 'main' into feature/4434

f0af9bb

Merge branch 'main' into feature/4434

a2746b3

marcphilipp requested changes Apr 11, 2025

View reviewed changes

YongGoose added 2 commits April 12, 2025 17:13

Merge branch 'main' into feature/4434

c555910

Apply comment

c82c098

Issue junit-team#4434

YongGoose requested a review from marcphilipp April 12, 2025 10:15

YongGoose force-pushed the feature/4434 branch from d2c7606 to ea24f14 Compare April 12, 2025 10:22

Test warning logs for CloseableResource without AutoCloseable

8a5b7fe

Issue junit-team#4434

YongGoose force-pushed the feature/4434 branch from ea24f14 to 8a5b7fe Compare April 12, 2025 10:26

Merge branch 'main' into feature/4434

e8cb1d3

marcphilipp requested changes Apr 14, 2025

View reviewed changes

YongGoose and others added 3 commits April 15, 2025 18:57

Merge branch 'main' into feature/4434

46a8df0

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/de…

7fab7eb

…scriptor/AbstractExtensionContext.java Co-authored-by: Marc Philipp <[email protected]>

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/de…

8057fe9

…scriptor/AbstractExtensionContext.java Co-authored-by: Marc Philipp <[email protected]>

YongGoose and others added 7 commits April 15, 2025 19:08

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/de…

ed2df61

…scriptor/AbstractExtensionContext.java Co-authored-by: Marc Philipp <[email protected]>

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/de…

a255a23

…scriptor/AbstractExtensionContext.java Co-authored-by: Marc Philipp <[email protected]>

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/de…

46a606d

…scriptor/AbstractExtensionContext.java Co-authored-by: Marc Philipp <[email protected]>

Apply comment

d7a985e

Issue junit-team#4434

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/co…

c05235e

…nfig/JupiterConfiguration.java Co-authored-by: Marc Philipp <[email protected]>

Update junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/co…

49cb3f5

…nfig/JupiterConfiguration.java Co-authored-by: Marc Philipp <[email protected]>

Update javadoc

d498200

Issue junit-team#4434

YongGoose requested a review from marcphilipp April 15, 2025 10:46

polishing

056d060

Issue junit-team#4434

YongGoose force-pushed the feature/4434 branch from 49cc225 to 056d060 Compare April 15, 2025 10:49

Update document

d25f1b0

Issue junit-team#4434

YongGoose force-pushed the feature/4434 branch from 3a96c24 to d25f1b0 Compare April 18, 2025 00:06

YongGoose and others added 4 commits April 18, 2025 16:40

Merge branch 'main' into feature/4434

30a4b01

Merge branch 'main' into feature/4434

96c46b0

Polishing

bcf642b

Merge branch 'main' into feature/4434

f2f8ade

marcphilipp approved these changes Apr 28, 2025

View reviewed changes

marcphilipp merged commit 1d81839 into junit-team:main Apr 28, 2025
13 checks passed

marcphilipp added theme: extensions component: Jupiter type: new feature labels Apr 28, 2025

Uh oh!

Introduce feature flag for auto-closing AutoCloseable in Jupiter's ExtensionContext.Store #4452

Introduce feature flag for auto-closing AutoCloseable in Jupiter's ExtensionContext.Store #4452

Uh oh!

Conversation

YongGoose commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Definition of Done

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcphilipp commented Apr 28, 2025

Uh oh!

YongGoose commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YongGoose commented May 8, 2025

Uh oh!

marcphilipp commented May 8, 2025

Uh oh!

YongGoose commented May 8, 2025

Uh oh!

YongGoose commented May 23, 2025

Uh oh!

marcphilipp commented May 23, 2025

Uh oh!

YongGoose commented May 23, 2025

Uh oh!

Uh oh!

Introduce feature flag for auto-closing `AutoCloseable` in Jupiter's ExtensionContext.Store #4452

Introduce feature flag for auto-closing `AutoCloseable` in Jupiter's ExtensionContext.Store #4452

YongGoose commented Apr 6, 2025 •

edited

Loading

YongGoose commented Apr 28, 2025 •

edited

Loading