Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

RiotQuest will move onto 7.4+ once 7.4 has been stabilized #22

@junlarsen

Description

@junlarsen

Is your feature request related to a problem? Please describe.
Once 7.4 has been released there will be major optimizations that can be done within the codebase. We will create a stable release for 7.1+ which will stay at that version. That branch will recieve updates if the League APIs change, but will not get new features.

Describe the solution you'd like
We leave a branch at 7.1+ support with a stable release and then move onto 2.0 with 7.4+ only support.

Describe alternatives you've considered
I have considered creating two branches which will be maintained and get new features, but I think it's going to be more beneficial to keep one branch stable for API updates and one for new features.

Code examples, if applicable
We will be replacing all old closures with the new short-closure syntax which is being introduced in 7.4. We will also add types on every class member. This potentially means a new DTO engine as we can typehint the types on props instead of reading from docblock.

Additional context
This proposal might change, we'll see how things evolve.

Metadata

Metadata

Assignees

Labels

status:pendingThe status of this issue is currently pendingtype:enhancementThis issue is a new feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions