Skip to content

Commit fede2de

Browse files
committed
MDL-84991 editor_tiny: Improve lang string generation instructions
1 parent 687232b commit fede2de

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

lib/editor/tiny/readme_moodle.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -102,15 +102,19 @@ sed -i "/string\['tiny:/d" "${MOODLEDIR}/lang/en/editor_tiny.php"
102102
cat strings.php >> "${MOODLEDIR}/lang/en/editor_tiny.php"
103103
```
104104

105-
7. Commit changes. Note: You may need to review individual language changes which do not meet Moodle's guidelines.
106-
8. If required, the remaining language strings can be fed into AMOS.
105+
7. Review the changes to the language strings file carefully. You may need to:
106+
107+
* Edit new strings so they meet [Moodle's guidelines for language strings](https://moodledev.io/general/development/policies/codingstyle#language-strings).
108+
* Revert changes to any Moodle-updated language strings that were fixed for spelling, grammar, and consistency in past releases to meet Moodle's guidelines. For example, from the [`en_fix` issues](https://tracker.moodle.org/issues/?jql=summary%20~%20%22en_fix%22%20order%20by%20createdDate%20desc). Review the `git` history of the language strings file to verify.
109+
110+
8. Commit the changes.
111+
112+
9. If required, the remaining language strings can be fed into AMOS.
107113

108114
---
109115

110116
**Note:** A set of language files are also generated for all supported translations and may be submitted to AMOS if desired.
111117

112-
**Note:** You will need to manually check for any Moodle-updated language strings as part of this change (for example any from the en_fixes).
113-
114118
---
115119

116120
## Security fix procedure for TinyMCE Editor

0 commit comments

Comments
 (0)