Remove 'getDylinkMetadata' from exported methods (#433)

davy39 · web-flow · commit c9920e345c04 · 2025-10-24T09:17:12.000+02:00
I tried to build xeus-ocaml with Emscripten 4x, but it throws error with undefined method. It may be [redundant](#433 (comment)) with MAIN_MODULE=1 Anyway, without it it builds and works fine, and and so does it with emscripten 3.73.
diff --git a/cmake/WasmBuildOptions.cmake b/cmake/WasmBuildOptions.cmake
@@ -34,7 +34,7 @@ function(xeus_wasm_link_options target environment)
         PUBLIC "SHELL: -s STACK_SIZE=32mb"
         PUBLIC "SHELL: -s INITIAL_MEMORY=128mb"
         PUBLIC "SHELL: -s WASM_BIGINT"
-        PUBLIC "SHELL: -s EXPORTED_RUNTIME_METHODS='[\"FS\",\"ENV\",\"PATH\",\"LDSO\",\"getDylinkMetadata\",\"loadDynamicLibrary\",\"ERRNO_CODES\"]'"
+        PUBLIC "SHELL: -s EXPORTED_RUNTIME_METHODS='[\"FS\",\"ENV\",\"PATH\",\"LDSO\",\"loadDynamicLibrary\",\"ERRNO_CODES\"]'"
         PUBLIC "SHELL: -s FORCE_FILESYSTEM"
         PUBLIC "SHELL: -s MAIN_MODULE=1"
     )

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ function(xeus_wasm_link_options target environment)`
`34`	`34`	`PUBLIC "SHELL: -s STACK_SIZE=32mb"`
`35`	`35`	`PUBLIC "SHELL: -s INITIAL_MEMORY=128mb"`
`36`	`36`	`PUBLIC "SHELL: -s WASM_BIGINT"`
`37`		`- PUBLIC "SHELL: -s EXPORTED_RUNTIME_METHODS='[\"FS\",\"ENV\",\"PATH\",\"LDSO\",\"getDylinkMetadata\",\"loadDynamicLibrary\",\"ERRNO_CODES\"]'"`
	`37`	`+ PUBLIC "SHELL: -s EXPORTED_RUNTIME_METHODS='[\"FS\",\"ENV\",\"PATH\",\"LDSO\",\"loadDynamicLibrary\",\"ERRNO_CODES\"]'"`
`38`	`38`	`PUBLIC "SHELL: -s FORCE_FILESYSTEM"`
`39`	`39`	`PUBLIC "SHELL: -s MAIN_MODULE=1"`
`40`	`40`	`)`