Skip to content

Commit ecaa90c

Browse files
committed
Simplify code in CondaPackageHelper
1 parent 24d8f65 commit ecaa90c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

tests/utils/conda_package_helper.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,9 @@ def find_updatable_packages(self, requested_only: bool) -> list[dict[str, str]]:
108108
updatable = []
109109
for pkg, inst_vs in self.installed_packages.items():
110110
avail_vs = self.available_packages[pkg]
111-
if (requested_only and pkg not in self.requested_packages) or (
112-
not avail_vs
113-
):
111+
if not avail_vs or (requested_only and pkg not in self.requested_packages):
114112
continue
115-
newest = sorted(avail_vs, key=CondaPackageHelper.semantic_cmp)[-1]
113+
newest = max(avail_vs, key=CondaPackageHelper.semantic_cmp)
116114
current = min(inst_vs, key=CondaPackageHelper.semantic_cmp)
117115
if CondaPackageHelper.semantic_cmp(
118116
current

0 commit comments

Comments
 (0)