Skip to content

Commit ded20d4

Browse files
jtpioCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent b03a2b4 commit ded20d4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

buildutils/src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export function pythonVersionToJSVersion(version: string): string {
9191
.replace(/\.dev(\d+)$/, '-dev.$1');
9292

9393
if (!semver.valid(jsVersion)) {
94-
throw new Error(`Invalid JavaScript version: ${version}`);
94+
throw new Error(`Invalid JavaScript version: ${jsVersion} (from Python version: ${version})`);
9595
}
9696

9797
return jsVersion;

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ build = "make -C docs html SPHINXOPTS='-W'"
125125
serve = "cd docs/build/html && python -m http.server"
126126

127127
[tool.hatch.envs.default.scripts]
128-
npm_pack = "node ./buildutils/lib/npm-pack.js"
128+
npm_pack = "jlpm run build:utils && node ./buildutils/lib/npm-pack.js"
129129
js_test = "jlpm run build:test && jlpm run test"
130130

131131
[tool.hatch.envs.test]

0 commit comments

Comments
 (0)