Skip to content

Fix the file browser default column width #7476

Open
@jtpio

Description

@jtpio

In #7423 we tried to make the file browser default column width stable.

But it looks like they are not by default, as reloading the page several times in a row would yield different widths for the columns.

The UI tests have added a maxDiffPixels to get around that for now just to be able to get a release out, here:

expect(await page.screenshot()).toMatchSnapshot('tree.png', {
maxDiffPixels: 500,
});

and here:

expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
maxDiffPixels: 500,
});

But we should clearly undo that change because the file browser should always open the same way.

cc @krassowski @JasonWeill I would appreciate if you could help have a look at this since you both worked on the upstream feature in JupyterLab. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions