Merge pull request #629 from Carreau/maybe-async

Test  async kernel manager

Author: ccordoba12

.github/workflows/linux-tests.yml

@@ -27,7 +27,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        PYTHON_VERSION: ['3.8', '3.9', '3.10', '3.11']
+        PYTHON_VERSION: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
         INSTALL_TYPE: ['conda', 'pip']
         QT_LIB: ['pyqt5', 'pyqt6']
         exclude:

qtconsole/tests/test_inprocess_kernel.py

@@ -3,29 +3,28 @@
 # Copyright (c) Jupyter Development Team.
 # Distributed under the terms of the Modified BSD License.
 
-import unittest
-
 from qtconsole.inprocess import QtInProcessKernelManager
-
-
-class InProcessTests(unittest.TestCase):
-
-    def setUp(self):
-        """Open an in-process kernel."""
-        self.kernel_manager = QtInProcessKernelManager()
-        self.kernel_manager.start_kernel()
-        self.kernel_client = self.kernel_manager.client()
-
-    def tearDown(self):
-        """Shutdown the in-process kernel. """
-        self.kernel_client.stop_channels()
-        self.kernel_manager.shutdown_kernel()
-
-    def test_execute(self):
-        """Test execution of shell commands."""
-        # check that closed works as expected
-        assert not self.kernel_client.iopub_channel.closed()
-        
-        # check that running code works
-        self.kernel_client.execute('a=1')
-        assert self.kernel_manager.kernel.shell.user_ns.get('a') == 1
+from inspect import iscoroutinefunction
+import pytest
+
+
+@pytest.mark.asyncio
+async def test_execute():
+    kernel_manager = QtInProcessKernelManager()
+    if iscoroutinefunction(kernel_manager.start_kernel):
+        await kernel_manager.start_kernel()
+    else:
+        kernel_manager.start_kernel()
+    kernel_client = kernel_manager.client()
+
+    """Test execution of shell commands."""
+    # check that closed works as expected
+    assert not kernel_client.iopub_channel.closed()
+
+    # check that running code works
+    kernel_client.execute("a=1")
+    assert kernel_manager.kernel is not None, "kernel has likely not started"
+    assert kernel_manager.kernel.shell.user_ns.get("a") == 1
+
+    kernel_client.stop_channels()
+    kernel_manager.shutdown_kernel()

setup.py

@@ -74,9 +74,9 @@
         'qtpy>=2.4.0',
         'packaging'
     ],
-    extras_require = {
-        'test': ['flaky', 'pytest', 'pytest-qt'],
-        'doc': 'Sphinx>=1.3',
+    extras_require={
+        "test": ["flaky", "pytest", "pytest-qt", "pytest-asyncio"],
+        "doc": "Sphinx>=1.3",
     },
     entry_points = {
         'gui_scripts': [