You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code review of the 2026-06-17 work surfaced small test-coverage gaps deliberately kept out of the original PRs to keep them reviewable.
Context / Checklist
Write tests and docs for multi-client support feature #293 (test_client_viewset.py): study clients DELETE path; consolidated_clients isolation (a client from an unrelated study is excluded) + the patient_invitations enrichment; a non-superuser 403 on a mutating client endpoint (PATCH/DELETE/data_sources).
Support US Core query modifiers #585 (test_fhir_search_common_params.py): gt/lt comparators; a bare-date value (whole day); the aux/UUID _id routing path. Also fix the misleading comment in apply_common_search_filters (it is the camelCase MIDDLEWARE, not the parser, that rewrites query keys).
Background
Code review of the 2026-06-17 work surfaced small test-coverage gaps deliberately kept out of the original PRs to keep them reviewable.
Context / Checklist
test_client_viewset.py): study clients DELETE path;consolidated_clientsisolation (a client from an unrelated study is excluded) + thepatient_invitationsenrichment; a non-superuser 403 on a mutating client endpoint (PATCH/DELETE/data_sources).test_fhir_search_common_params.py):gt/ltcomparators; a bare-date value (whole day); the aux/UUID_idrouting path. Also fix the misleading comment inapply_common_search_filters(it is the camelCase MIDDLEWARE, not the parser, that rewrites query keys).test_fhir_observation_subject_identifier.py): assert FHIR validity in the no-jhe_usercase; assertsubject.identifierper entry in a multi-observation search Bundle.test_observation_admin.py): admin POST save-path - save an Observation withdata_sourceblank and assert it persists (not just that the form field is optional).Acceptance Criteria