Skip to content

Commit fc8ba66

Browse files
authored
Merge pull request #3235 from yuvipanda/mtu
Explicitly set docker's MTU to 1450
2 parents 6379bd8 + 4ea3cdd commit fc8ba66

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

config/hetzner-2i2c-bare.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,6 @@ binderhub:
6565
GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json
6666

6767
dind:
68-
daemonset:
69-
extraArgs:
70-
# Increase limit from default of 5, as we have only one builder node
71-
# But there are enough resources on the node to handle it
72-
- --max-concurrent-uploads=32
7368
resources:
7469
requests:
7570
cpu: "4"

config/hetzner-2i2c.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ binderhub:
6363
GOOGLE_APPLICATION_CREDENTIALS: /secrets/service-account.json
6464

6565
dind:
66-
daemonset:
67-
extraArgs:
68-
# Increase limit from default of 5, as we have only one builder node
69-
# But there are enough resources on the node to handle it
70-
- --max-concurrent-uploads=32
7166
resources:
7267
requests:
7368
cpu: "4"

mybinder/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,14 @@ binderhub:
345345

346346
imageBuilderType: dind
347347
dind:
348+
daemonset:
349+
extraArgs:
350+
# Allow for concurrent pushes so pushes are faster
351+
- --max-concurrent-uploads=32
352+
# Set mtu explicitly to 1450, as sometimes docker sets it to 1500
353+
# instead and that breaks *some* websites randomly *some* of the time
354+
# See https://discourse.jupyter.org/t/error-in-mybinder-org-there-is-no-package-called-irkernel/32478/17
355+
- --mtu=1450
348356
resources:
349357
requests:
350358
cpu: "0.5"

0 commit comments

Comments
 (0)