Move login command inside try so we clear env correctly

jupyterhub · Feb 28, 2025 · 342eea9 · 342eea9
1 parent d3facba
commit 342eea9
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/repo2docker/docker.py b/repo2docker/docker.py
@@ -190,19 +190,19 @@ def docker_login(self, username, password, registry):
                 shutil.copy2(dc_path, new_dc_path)
 
             os.environ["DOCKER_CONFIG"] = d
-            proc = subprocess.run(
-                [
-                    "docker",
-                    "login",
-                    "--username",
-                    username,
-                    "--password-stdin",
-                    registry,
-                ],
-                input=password.encode(),
-                check=True,
-            )
             try:
+                subprocess.run(
+                    [
+                        "docker",
+                        "login",
+                        "--username",
+                        username,
+                        "--password-stdin",
+                        registry,
+                    ],
+                    input=password.encode(),
+                    check=True,
+                )
                 yield
             finally:
                 if old_dc_path: