case sensitivity issue with postBuild

[minrk]

I think it's generally discouraged to make executable scripts case-sensitive. This can cause issues with version control on case-insensitive filesystems (e.g. most macs by default). The norm for multi-word commands on unix is to use hyphens (post-build).

Should we try to migrate postBuild to a more standard post-build? Or the case-insensitive equivalent postbuild which would behave the same on case-insensitive filesystems, but I think is more likely to cause a problem during a transition (git can get real confused when you have both postBuild and postbuild).

[betatim]

I'd be happy to move towards post-build.

As a transition plan: we could start supporting postBuild and post-build for two (?) releases and print a warning when people use postBuild prompting them to upgrade (these would be releases X-3 and X-2). Then in the X-1 version we make it an error. In version X only post-build is supported. WDYT?

(If only we had versioned repo2docker support ... :) )

ps. which file systems are the ones that are case insensitive/tricky to work with?

[minrk]

which file systems are the ones that are case insensitive/tricky to work with?

The main filesystems folks encounter these days that are case insensitive by default are HFS+ and APFS, which is to say approximately all mac users and approximately nobody else.

As a transition plan

If we do it, I think we can deprecate postBuild with a warning and keep it working ~forever. A good policy I've come to adopt is that deprecated functionality should never be removed until its presence causes a problem of some kind. Keeping support for an old filename should be an easy one-time check to keep around that we don't benefit from removing.

[manics]

Is this still something we'd like to do? I'm (naively?) guessing it's relatively simple, list all files and look for a case-insensitive match.