Skip to content

Commit 2f1e7b2

Browse files
authored
Migrate shortcut selectors for JupyterLab 4.1+ (#135)
* Migrate shortcuts to JupyterLab 4.1 * Require JupyterLab 4.1
1 parent 4832d99 commit 2f1e7b2

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

pyproject.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ classifiers = [
2222
"Programming Language :: Python :: 3.11",
2323
]
2424
dependencies = [
25-
"jupyterlab>=4.0.0,<5"
25+
"jupyterlab>=4.1.0,<5"
2626
]
2727
dynamic = ["version", "description", "authors", "urls", "keywords"]
2828

@@ -67,7 +67,7 @@ version_cmd = "hatch version"
6767

6868
[tool.jupyter-releaser.hooks]
6969
before-build-npm = [
70-
"python -m pip install 'jupyterlab>=4.0.0,<5'",
70+
"python -m pip install 'jupyterlab>=4.1.0,<5'",
7171
"jlpm",
7272
"jlpm build:prod"
7373
]

schema/plugin.json

+20-20
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"command": "notebook:extend-marked-cells-below"
5757
},
5858
{
59-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
59+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
6060
"keys": ["Ctrl Shift J"],
6161
"command": "notebook:extend-marked-cells-below"
6262
},
@@ -66,7 +66,7 @@
6666
"command": "notebook:extend-marked-cells-above"
6767
},
6868
{
69-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
69+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
7070
"keys": ["Ctrl Shift K"],
7171
"command": "notebook:extend-marked-cells-above"
7272
},
@@ -116,7 +116,7 @@
116116
"command": "vim:leave-current-mode"
117117
},
118118
{
119-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
119+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
120120
"keys": ["Ctrl I"],
121121
"command": "vim:enter-insert-mode"
122122
},
@@ -141,7 +141,7 @@
141141
"command": "vim:no-action"
142142
},
143143
{
144-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
144+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
145145
"keys": ["Shift M"],
146146
"command": "vim:merge-and-edit"
147147
},
@@ -171,82 +171,82 @@
171171
"command": "vim:select-last-cell"
172172
},
173173
{
174-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
174+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
175175
"keys": ["G", "G"],
176176
"command": "vim:select-first-cell"
177177
},
178178
{
179-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
179+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
180180
"keys": ["Shift G"],
181181
"command": "vim:select-last-cell"
182182
},
183183
{
184-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
184+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
185185
"keys": ["Y", "Y"],
186186
"command": "notebook:copy-cell"
187187
},
188188
{
189189
"command": "notebook:cut-cell",
190190
"keys": ["D", "D"],
191-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus"
191+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)"
192192
},
193193
{
194-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
194+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
195195
"keys": ["Shift P"],
196196
"command": "notebook:paste-cell-above"
197197
},
198198
{
199-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
199+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
200200
"keys": ["P"],
201201
"command": "notebook:paste-cell-below"
202202
},
203203
{
204-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
204+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
205205
"keys": ["O"],
206206
"command": "notebook:insert-cell-below"
207207
},
208208
{
209-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
209+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
210210
"keys": ["Shift O"],
211211
"command": "notebook:insert-cell-above"
212212
},
213213
{
214-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
214+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
215215
"keys": ["U"],
216216
"command": "notebook:undo-cell-action"
217217
},
218218
{
219-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
219+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
220220
"keys": ["Ctrl E"],
221221
"command": "notebook:move-cell-down"
222222
},
223223
{
224-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
224+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
225225
"keys": ["Ctrl Y"],
226226
"command": "notebook:move-cell-up"
227227
},
228228
{
229-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
229+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
230230
"keys": ["Z", "Z"],
231231
"command": "vim:center-cell"
232232
},
233233
{
234-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
234+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
235235
"keys": ["Z", "C"],
236236
"command": "notebook:hide-cell-code"
237237
},
238238
{
239-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
239+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
240240
"keys": ["Z", "O"],
241241
"command": "notebook:show-cell-code"
242242
},
243243
{
244-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
244+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
245245
"keys": ["Z", "M"],
246246
"command": "notebook:hide-all-cell-code"
247247
},
248248
{
249-
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus",
249+
"selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook.jp-mod-commandMode :focus:not(:read-write)",
250250
"keys": ["Z", "R"],
251251
"command": "notebook:show-all-cell-code"
252252
},

0 commit comments

Comments
 (0)