Dirty dot still appears, although changes are persisted within 1 second

[JasonWeill]

Description

After the user makes a change to a notebook while Jupyter Collaboration is enabled, the dirty dot appears in the tab bar inside JupyterLab, as if the user needs to save the file to make their change persist on disk (#364). By default, as of JupyterLab version 4.3.0, the timeout is 120 seconds (jupyterlab/jupyterlab#5619), so the dot continues to appear for 2 minutes after the most recent change. However, changes are persisted on disk after a delay, set in the RTC code, that defaults to only 1 second: (thanks @dlqqq for sharing this)

jupyter-collaboration/projects/jupyter-server-ydoc/jupyter_server_ydoc/app.py

Lines 59 to 65 in 515d362

	document_save_delay = Float(
	1,
	allow_none=True,
	config=True,
	help="""The delay in seconds to wait after a change is made to a document before saving it.
	Defaults to 1s, if None then the document will never be saved.""",
	)

Expected behavior

When changes are persisted on disk, the "dirty dot" should not be visible for the opened file.

Context

Per @dlqqq, the “dirty indicator” shown in the frontend is toggled via notebook.dirty = {True, False} in the Python server implementation.

• JupyterLab version: 4.2.5, with jupyter-collaboration 2.1.5