Save immediately when triggering manual save#540
Merged
krassowski merged 5 commits intojupyterlab:mainfrom Feb 4, 2026
Merged
Conversation
Should fix jupyterlab#537. I'm not sure between a parameter, and have a different function. And not quite sure why the require-hash was missing.
Contributor
|
|
krassowski
reviewed
Feb 3, 2026
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
There are a few linting/type issues but it looks good to me otherwise!
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Contributor
Author
|
ran precommit, let's see if that fixes it. |
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #537.
I'm not sure between a parameter, and have a different function. And not quite sure why the require-hash was missing.