Commit 6253eec
committed
Guard the title bar drag region with an e2e test
The title bar renders inside its own WebContentsView and window dragging
depends on the app-region CSS staying put: a drag surface on the title and a
no-drag opt-out on every control. A refactor that drops either rule breaks
window moving or the buttons with no signal from the type checker or the unit
suite. Pin the computed declarations so that regression fails loudly.
The real OS window move cannot be driven from Playwright since synthetic mouse
events do not trigger the app-region hit-test, so this stays a CSS guard and the
actual drag plus the layered-view no-drag behavior remain manual per OS. The
focus fixes in this branch (welcome view focus in Welcome mode, background
window not stealing focus) resist a deterministic e2e assertion too: the app
never becomes OS-frontmost under the test harness, so webContents.isFocused()
always reads false and any assertion would be tautological. Those stay manual
and are written up in the PR. I worked these tests and the harness probing out
with Claude Code and confirmed the guard fails when the drag rule is removed.1 parent d5d92cc commit 6253eec
1 file changed
Lines changed: 71 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
0 commit comments