ci: install the Electron binary in one deterministic step

Replace install.js plus the two per-OS repair steps with a single step: skip
the flaky extract-zip postinstall (ELECTRON_SKIP_BINARY_DOWNLOAD), resolve the
cached zip with @electron/get (same call on every OS), and extract with the
system tool (ditto on macOS to keep the framework symlinks, unzip on Linux).
No more let-it-break-then-repair, and one mechanism instead of two.

Note: AI-assisted (Claude Code). Manually verified: @electron/get without an
explicit platform resolves the runner's own zip; install.js honors
ELECTRON_SKIP_BINARY_DOWNLOAD; the macOS ditto extraction yields a complete
.app locally.

Author: notluquis

.github/workflows/e2e.yml

@@ -28,6 +28,9 @@ jobs:
       # Only Electron is launched here, never Playwright's bundled browsers, so
       # skip their download during yarn install (faster, fewer network flakes).
       PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
+      # electron's postinstall (extract-zip) intermittently drops files from dist
+      # on CI runners, so skip it and install the binary deterministically below.
+      ELECTRON_SKIP_BINARY_DOWNLOAD: '1'
     steps:
       - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
@@ -37,52 +40,27 @@ jobs:
           node-version: '24.x'
           cache: 'yarn'
       - run: yarn install --frozen-lockfile
-      # The electron postinstall (extract-zip) intermittently leaves dist without
-      # the binary on CI runners (it happens on macOS too, not just Linux), so
-      # launch fails with "Electron failed to install correctly". Run install.js
-      # explicitly on every OS to fetch and extract the binary.
+      # Install the Electron binary deterministically instead of relying on the
+      # flaky extract-zip postinstall. Resolve the cached zip with @electron/get
+      # (electron's own download dep, same call on every OS) and extract it with
+      # the system tool: macOS needs ditto to keep the Electron Framework
+      # symlinks that plain unzip mangles; Linux uses unzip. Then point path.txt
+      # at the binary and confirm require('electron') resolves.
       - name: Install the Electron binary
-        run: node node_modules/electron/install.js
-      # On Linux, if extract-zip still dropped the binary, fall back to system
-      # unzip (the zip is the linux-x64 build, binary at dist/electron).
-      - name: Repair the Electron binary on Linux if needed
-        if: matrix.os == 'ubuntu-latest'
+        shell: bash
         run: |
           set -euo pipefail
-          if [ ! -x node_modules/electron/dist/electron ]; then
-            echo "linux electron binary missing, repairing from the cached zip"
-            zip=$(ls ~/.cache/electron/*/electron-*-linux-x64.zip | head -1)
-            rm -rf node_modules/electron/dist
-            mkdir -p node_modules/electron/dist
-            unzip -q -o "$zip" -d node_modules/electron/dist
-            printf 'electron' > node_modules/electron/path.txt
+          zip=$(node -e "const {downloadArtifact}=require('@electron/get');const {version}=require('electron/package.json');downloadArtifact({version,artifactName:'electron'}).then(p=>process.stdout.write(p)).catch(e=>{console.error(e);process.exit(1)})")
+          dist=node_modules/electron/dist
+          rm -rf "$dist" && mkdir -p "$dist"
+          if [ "$RUNNER_OS" = "macOS" ]; then
+            ditto -x -k "$zip" "$dist"
+            printf 'Electron.app/Contents/MacOS/Electron' > node_modules/electron/path.txt
+            test -f "$dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework"
           else
-            echo "linux electron binary present, no repair needed"
+            unzip -q -o "$zip" -d "$dist"
+            printf 'electron' > node_modules/electron/path.txt
           fi
-          test -x node_modules/electron/dist/electron
-      # extract-zip produces a broken Electron.app on the macOS runner: the
-      # launcher at Contents/MacOS/Electron is present but Contents/Frameworks/
-      # Electron Framework.framework is incomplete, so dyld fails with "Library
-      # not loaded" at launch, and path.txt is never written either. Re-extract
-      # the cached darwin zip with ditto, which reproduces a complete .app
-      # (framework binary plus the Versions/Current symlinks plain unzip mangles)
-      # locally, then write path.txt (its macOS value is constant) and verify
-      # both the launcher and the framework binary are in place.
-      - name: Repair the Electron install on macOS
-        if: matrix.os == 'macos-latest'
-        run: |
-          set -euo pipefail
-          # Ask @electron/get (electron's own download dep) for the cached zip,
-          # fetching it if absent. It stores the zip under a content-hash subdir,
-          # so globbing the cache root misses it; let the library resolve the path.
-          zip=$(node -e "const {downloadArtifact}=require('@electron/get');const {version}=require('electron/package.json');downloadArtifact({version,artifactName:'electron',platform:'darwin',arch:process.arch}).then(p=>process.stdout.write(p)).catch(e=>{console.error(e);process.exit(1)})")
-          echo "re-extracting electron from $zip"
-          rm -rf node_modules/electron/dist
-          mkdir -p node_modules/electron/dist
-          ditto -x -k "$zip" node_modules/electron/dist
-          printf 'Electron.app/Contents/MacOS/Electron' > node_modules/electron/path.txt
-          test -x "node_modules/electron/dist/Electron.app/Contents/MacOS/Electron"
-          test -f "node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework"
           node -e "console.log('resolved electron:', require('electron'))"
       - run: yarn build
       # Electron needs system libraries; xvfb provides a display on the headless